Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rolling-update actually parse filenames from stdin #8679

Merged
merged 1 commit into from
May 27, 2015
Merged

Make rolling-update actually parse filenames from stdin #8679

merged 1 commit into from
May 27, 2015

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented May 22, 2015

Closes #7286.

@bgrant0607
Copy link
Member

LGTM.

cc @ironcladlou

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2015
@ironcladlou
Copy link
Contributor

LGTM.

saad-ali added a commit that referenced this pull request May 27, 2015
@saad-ali
Merge pull request #8679 from jlowdermilk/rolling-update-stdin
ee82d46 
Make rolling-update actually parse filenames from stdin
@saad-ali saad-ali merged commit ee82d46 into kubernetes:master May 27, 2015
@j3ffml j3ffml deleted the rolling-update-stdin branch May 29, 2015 17:12
@j3ffml j3ffml mentioned this pull request May 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rolling-update doesn't actually accept a file from stdin
5 participants
@j3ffml @bgrant0607 @ironcladlou @googlebot @saad-ali