New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test to patch a secret #86857
Merged
k8s-ci-robot
merged 6 commits into
kubernetes:master
from
ii:create-secret-patching-test
Jan 11, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
edd612d
Add: test to patch a secret
BobyMCbobs c5e3ab1
Fix: formatting, spelling
BobyMCbobs ab12f46
Update: to use framework instead of gomega for testing values
BobyMCbobs b4fb464
Update: test secret contains a default label, secrets are listed via …
BobyMCbobs 07e3c46
Add: secret data patch check
BobyMCbobs dcd4dcd
Update: comments, searching for secrets in lists
BobyMCbobs File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO once we've patched the secret, we should get the secret back and confirm the patch has taken effect. As written this test could be satisfied by an endpoint that does nothing but return 200 OK. So here I would once again locate the secret by name/namespace (might want to pull out into a helper func), and then verify its data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this idea, I've updated the test to include the check in 07e3c46.