Fixed CanSupport func across all volumes (for PV) #8732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markturansky
force-pushed
the
missing_pv_support
branch
from
92a94c4
to
3ad583c
Compare
| @@ -40,6 +40,9 @@ func TestCanSupport(t *testing.T) { | |||
| if !plug.CanSupport(&volume.Spec{Name: "foo", VolumeSource: api.VolumeSource{AWSElasticBlockStore: &api.AWSElasticBlockStoreVolumeSource{}}}) { | |||
| t.Errorf("Expected true") | |||
| } | |||
| if !plug.CanSupport(&volume.Spec{Name: "foo", PersistentVolumeSource: api.PersistentVolumeSource{AWSElasticBlockStore: &api.AWSElasticBlockStoreVolumeSource{}}}) { | |||
There was a problem hiding this comment.
this is kind of a mouthful... maybe consider defining & checking on separate lines, for readability?
There was a problem hiding this comment.
eh... it looks like this file is already this way. I guess it's better to stay consistent.
thockin
added
the
lgtm
|
LGTM |
9 tasks
thockin
added a commit
that referenced
this pull request
May 27, 2015
Fixed CanSupport func across all volumes (for PV)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanSupport for PV was spotty across volumes.
NFS is covered in #8688.
ISCSI is covered #8133.
Added a test for ISCSI in this PR, though, because #8133 is already flagged ready to go.
@thockin