WIP: Continue to support (deprecated) publicIPs #8739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing so breaks e2e tests and people that may be using them, even though we will eventually want to stop supporting this now that we have better alternatives for typical use cases (NodePort)
|
LGTM - merging to try and get e2e green. |
lavalamp
added a commit
that referenced
this pull request
May 24, 2015
WIP: Continue to support (deprecated) publicIPs
|
@thockin can you do a retroactive review? |
|
tentative result: only one run but services.sh passed and it was solid red before, so that's an improvement, at least. |
thockin
added
the
lgtm
|
LGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing so breaks e2e tests and people that may be using them,
even though we will eventually want to stop supporting this now
that we have better alternatives for typical use cases (NodePort)