Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test images: Adds Image Promoter details in the README #87611

Merged

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jan 28, 2020

What type of PR is this?

/kind documentation

What this PR does / why we need it:

We have enabled the Image Promoter on the k/k test E2E images. This updates the kubernetes/test/images/README.md file to include information about the images it runs for, and how to promote the new image from the staging registry to the regular one.

Cleans up some TODO items, since the Image Centralization Part 4 merged.

Which issue(s) this PR fixes:

Related: #76342

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2020
@claudiubelu
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2020
@claudiubelu claudiubelu force-pushed the test-images/updates-readme branch 2 times, most recently from 68feeef to bf7e630 Compare January 28, 2020 16:45
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6-parallel

We have enabled the Image Promoter on the k/k test E2E images. This updates the
kubernetes/test/images/README.md file to include information about the images
it runs for, and how to promote the new image from the staging registry to the
regular one.

Cleans up some TODO items, since the Image Centralization Part 4 merged.
@claudiubelu
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2020
@claudiubelu
Copy link
Contributor Author

/retest

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

1 similar comment
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@claudiubelu
Copy link
Contributor Author

/retest

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

4 similar comments
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@johnbelamaric
Copy link
Member

/lgtm
/priority important-longterm
/assign @listx

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 18, 2020
@listx
Copy link

listx commented Feb 21, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2e0760c into kubernetes:master Feb 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants