Parameterize minStartupPods #8793
Conversation
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
|
@mbforbes @timothysc @rrati @eparis ok heres the parameter thingy we need so you can use |
|
+1 to option enable on this param. |
ixdy
added
the
lgtm
|
It'd probably be good to update the various platforms in |
| // are found to be running and ready; it ensures that *all* pods it finds | ||
| // are running and ready. This is the minimum number it must find. | ||
| // TODO : Add command line option for this so that the number is non trivial. | ||
| minStartupPods = 0 |
There was a problem hiding this comment.
Hahaha, that giant comment I wrote so that people would understand the function. No more!
There was a problem hiding this comment.
yeah... unfortunately the comment already didn't match the line following it.
maybe everything after "More verbosely" should be moved to the comment for waitForPodsRunningReady.
|
Please triage wrt code freeze |
|
just to confirm : are we triaging e2e updates ? |
|
Sorry, you're right, I was too quick. Needs rebase, though |
|
ah yes, ok ill rebase against some other pending prs also |
|
sorry, still needs rebase |
|
I am on-call, no can do today |
|
removing LGTM |
thockin
removed
the
lgtm
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
ok finally rebased ....... ready to look at again |
mbforbes
added
the
lgtm
|
LGTM, thanks |
Parameterize minStartupPods
heres a quickie to parameterize minStartupPods ( #8666 ).