Sleep before deleting the cluster to give the controller manager time to #8816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this for v1.0 milestone since it fixes test instability. Assigning @quinton-hoole |
| @@ -222,5 +222,8 @@ fi | |||
|
|
|||
| ### Clean up ### | |||
| if [[ "${E2E_DOWN,,}" == "true" ]]; then | |||
| # Sleep before deleting the cluster to give the controller manager time to | |||
| # delete any cloudprovider resources still around from the last test. | |||
| sleep 60 | |||
There was a problem hiding this comment.
Please add a note as to how the number 60 was arrived at (presumably based on the ELB retry loop frequency), and that it should not be changed independently of that basis.
There was a problem hiding this comment.
The deletions are managed using a watch and failed attempts to reconcile are retried every 5 seconds, so 60 is sort of an arbitrary bound. I've added a comment in the next push.
|
One nit. Other than that, LGTM. |
delete any cloudprovider resources still around from the last test.
a-robinson
added
the
lgtm
saad-ali
added a commit
that referenced
this pull request
May 26, 2015
Sleep before deleting the cluster to give the controller manager time to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete any cloudprovider resources still around from the last test.
Should (hopefully) fix #7753.
@quinton-hoole @zmerlynn