New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-1.18 publishing rules #88431
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM, but I'll let a @kubernetes/publishing-bot-reviewers sign off officially. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, one comment.
branch: release-1.18 | ||
dir: staging/src/k8s.io/code-generator | ||
name: release-1.18 | ||
go: 1.13.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liggitt -- Should these be 1.13.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't really matter, this is just for the bot to test with, and 1.13.x is sufficient. If we want to update this we should do it separately and update the levels for all the branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. We can take care of that after the 1.13.7 bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -124,10 +145,21 @@ rules: | |||
branch: release-1.17 | |||
- repository: api | |||
branch: release-1.17 | |||
- source: | |||
branch: release-1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see client-go following the branch nomenclature as other repos :)
/retest
…On Sun, Feb 23, 2020 at 1:01 PM Kubernetes Prow Robot < ***@***.***> wrote:
@liggitt <https://github.com/liggitt>: The following test *failed*, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce a6dc7ba
<a6dc7ba>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/88431/pull-kubernetes-e2e-gce/1231467089533865988/> /test
pull-kubernetes-e2e-gce
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=88431>. Your
PR dashboard <https://gubernator.k8s.io/pr/liggitt>. Please help us cut
down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#88431?email_source=notifications&email_token=AD24BUCWIM3JWI5OYJFVZQTREIQ3NA5CNFSM4KZWBRJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVTWWQ#issuecomment-590035802>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUFBOKH5TJESGPP6VTTREIQ3NANCNFSM4KZWBRJA>
.
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds staging repo publishing rules for release-1.18
Which issue(s) this PR fixes:
Fixes #88376
Fixes #88277
/sig release
/cc @sttts @nikhita @justaugustus