Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: fix the bug that 'kubeadm upgrade' hangs in single node cluster #88434
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
given the minimal bandwidth that we have to monitor and update our e2e tests, i'd argue that the maintenance burden will not be justified for having single-CP upgrade tests for all branches.
but something to note here is that our current e2e tests does not drain/cordon at all:
so possibly this is something that can be done first.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing