Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all storage Operation Generator functions to remove top level errors reducing event spam. Functionality moved to inner retryable/backoffable funcs #88537

Closed
wants to merge 1 commit into from
Closed

Refactor all storage Operation Generator functions to remove top level errors reducing event spam. Functionality moved to inner retryable/backoffable funcs #88537

wants to merge 1 commit into from

Conversation

davidz627
Copy link
Contributor

/kind cleanup
/assign @misterikkit @msau42
/cc @saad-ali @jingxu97 @mucahitkurt

Fixes #74988

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 25, 2020
@davidz627
Copy link
Contributor Author

/assign @jsafrane

@davidz627
Copy link
Contributor Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 25, 2020
@davidz627
Copy link
Contributor Author

/retest

2 similar comments
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Member

jsafrane commented Mar 2, 2020

Fixes #74988

#74988 mentions errors in GenerateAttachVolumeFunc, but the function does not return errors any longer. Still, similar change should be done in all other operations.

/approve

I'd like Hemant or Jing to approve that there are no important errors accidentally hidden now.
/assign @gnufied @jingxu97

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@davidz627
Copy link
Contributor Author

/assign @gnufied @jingxu97

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 3, 2020
@davidz627
Refactor all storage Operation Generator functions to remove top leve…
361ca5a 
…l errors reducing event spam. Functionality moved to inner retryable/backoffable funcs
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2020
@davidz627
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@davidz627: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2020
@davidz627
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@davidz627: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@mucahitkurt mucahitkurt Awaiting requested review from mucahitkurt

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@jsafrane jsafrane

@misterikkit misterikkit

@jingxu97 jingxu97

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event spam in some storage Operation Generator functions
7 participants
@davidz627 @jsafrane @k8s-ci-robot @gnufied @misterikkit @jingxu97 @msau42