Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple endpoint slice batching #88745

Merged
merged 1 commit into from Mar 3, 2020
Merged

Conversation

@mborsz
Copy link
Member

mborsz commented Mar 2, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR implements a simple endpoint slice batching. This tries to copy logic from #80509 to endpoint slice controller.

Those changes are disabled by default.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New flag --endpointslice-updates-batch-period in kube-controller-manager can be used to reduce number of endpointslice updates generated by pod changes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/assign @lavalamp

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 2, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Mar 2, 2020

/approve

OK from API and design perspective. Looks like the verify test is angry and a release note is needed, you can get an lgtm from anyone once you fix that.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mm4tt

This comment has been minimized.

Copy link
Contributor

mm4tt commented Mar 3, 2020

/lgtm

Thanks @mborsz and @lavalamp!

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit c86aec0 into kubernetes:master Mar 3, 2020
15 of 16 checks passed
15 of 16 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.