Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress alternate backends #88775

Merged
merged 1 commit into from Mar 6, 2020
Merged

Conversation

@cmluciano
Copy link
Member

cmluciano commented Mar 3, 2020

Co-authored-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR implements the Resource field within the Ingress package and also prepares for 1.19 refactoring of the service types

Which issue(s) this PR fixes:
xref:

Special notes for your reviewer:

  • Test Create and Update to be sure field isn't allowed on create for 1.18
  • Add validation tests for resource
  • Generate code properly

Does this PR introduce a user-facing change?:

ingress: Add alternate backends via TypedLocalObjectReference

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

@cmluciano

This comment has been minimized.

Copy link
Member Author

cmluciano commented Mar 3, 2020

@liggitt liggitt requested review from robscott and liggitt and removed request for caseydavenport and brendandburns Mar 3, 2020
@liggitt liggitt self-assigned this Mar 3, 2020
@liggitt liggitt added this to Assigned in API Reviews Mar 3, 2020
@liggitt liggitt added this to the v1.18 milestone Mar 3, 2020
@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch from 737f518 to cbaa920 Mar 3, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 4, 2020

pathType is merged if you want to rebase this on master now

pkg/apis/networking/types.go Outdated Show resolved Hide resolved
pkg/apis/networking/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/networking/validation/validation.go Outdated Show resolved Hide resolved
@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch from cbaa920 to 0729e6d Mar 4, 2020
@k8s-ci-robot k8s-ci-robot removed the size/XXL label Mar 4, 2020
@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch from de07e29 to 05e16e7 Mar 4, 2020
@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch from 05e16e7 to 8b1c31f Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Mar 5, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 5, 2020

/approve

field addition and validation lgtm. will tag once unit tests are complete

/retest

@liggitt liggitt moved this from Assigned to API review completed, 1.18 in API Reviews Mar 5, 2020
@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch from 8b1c31f to 5731760 Mar 5, 2020
@cmluciano cmluciano requested a review from liggitt Mar 5, 2020
"nil spec.Backend.Resource and no paths": {
tweakIngress: func(ing *networking.Ingress) {
ing.Spec.Backend = &networking.IngressBackend{
Resource: &api.TypedLocalObjectReference{},

This comment has been minimized.

Copy link
@liggitt

liggitt Mar 5, 2020

Member

the description says nil spec.Backend.Resource, but this isn't nil

},
"nil spec.Backend, one rule with nil HTTP ": {
tweakIngress: func(ing *networking.Ingress) {
ing.Spec.Backend = &networking.IngressBackend{}

This comment has been minimized.

Copy link
@liggitt

liggitt Mar 5, 2020

Member

should be nil to match description?

@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch 2 times, most recently from 8080af5 to 374610e Mar 5, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 5, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@cmluciano cmluciano force-pushed the cmluciano:cml/altbackend branch from 374610e to 912f05b Mar 5, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 5, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 5, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 5, 2020

/retest

1 similar comment
@cmluciano

This comment has been minimized.

Copy link
Member Author

cmluciano commented Mar 5, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit edf460b into kubernetes:master Mar 6, 2020
15 of 16 checks passed
15 of 16 checks passed
tide Not mergeable. Retesting: pull-kubernetes-e2e-gce-100-performance
Details
cla/linuxfoundation cmluciano authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
API Reviews
API review completed, 1.18
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.