Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of GCE PD CSI Driver used in tests for various features/fixes #88831

Closed
wants to merge 1 commit into from
Closed

Update version of GCE PD CSI Driver used in tests for various features/fixes #88831

wants to merge 1 commit into from

Conversation

davidz627
Copy link
Contributor

Fixes: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#433
/sig storage
/kind bug
/kind test-failure
/priority important-soon
/assign @gnufied @msau42

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

@davidz627: The label(s) kind/test-failure cannot be applied, because the repository doesn't have them

In response to this:

Fixes: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#433
/sig storage
/kind bug
/kind test-failure
/priority important-soon
/assign @gnufied @msau42

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2020
@k8s-ci-robot k8s-ci-robot requested review from gnufied, thockin and a team March 5, 2020 01:54
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidz627
To complete the pull request process, please assign wojtek-t
You can assign the PR to them by writing /assign @wojtek-t in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@davidz627: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-dependencies 926dd67 link /test pull-kubernetes-dependencies
pull-kubernetes-e2e-gce 926dd67 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-storage-snapshot 926dd67 link /test pull-kubernetes-e2e-gce-storage-snapshot

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Mar 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
gnufied
gnufied reviewed Mar 5, 2020
View reviewed changes
go.mod
k8s.io/system-validators v1.0.4
k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
sigs.k8s.io/kustomize v2.0.3+incompatible
sigs.k8s.io/structured-merge-diff/v3 v3.0.0-20200207200219-5e70324e7c1c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these changes btw? Did you had to update dependencies too?

@gnufied
Copy link
Member

gnufied commented Mar 5, 2020

Cancelling lgtm for a bit. To get some questions answered.

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@msau42
Copy link
Member

msau42 commented Mar 5, 2020

Sorry we miscommunicated and I have a similar pr out #88830

@davidz627 davidz627 closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@gnufied gnufied

@msau42 msau42

Labels
area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in NodeExpandVolume
4 participants
@davidz627 @k8s-ci-robot @gnufied @msau42