Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic certificates issues #88850

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Fix dynamic certificates issues #88850

merged 3 commits into from
Mar 6, 2020

Commits on Mar 5, 2020

  1. dynamic certs: do not copy mutex via shallow copy of tls.Config 

    go vet error:

call of dynamiccertificates.NewDynamicServingCertificateController
copies lock value: crypto/tls.Config contains sync.Once contains
sync.Mutex

Signed-off-by: Monis Khan <mok@vmware.com>
    @enj
    enj committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    86a5993 View commit details
    Browse the repository at this point in the history

  2. dynamic certs: use correct name with event recorder 

    Signed-off-by: Monis Khan <mok@vmware.com>
    @enj
    enj committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    3bc918e View commit details
    Browse the repository at this point in the history

  3. dynamic certs: pass valid object to event recorder 

    Signed-off-by: Monis Khan <mok@vmware.com>
    @enj
    enj committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    2cd6abe View commit details
    Browse the repository at this point in the history