Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil cpuManager in container manager #88857

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Check for nil cpuManager in container manager #88857

merged 1 commit into from
Mar 6, 2020

Conversation

nolancon
Copy link

@nolancon nolancon commented Mar 5, 2020 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR is in response to #88855 with patch suggested in #87759 to check for nil cpuManager as can be the case when beta feature is disabled.

Which issue(s) this PR fixes:
Fixes #88855

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 5, 2020
@nolancon nolancon changed the title Check for nil cpuManager Check for nil cpuManager in container manager Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2020
@klueska
Copy link
Contributor

klueska commented Mar 5, 2020

/approve

@nolancon nolancon mentioned this pull request Mar 5, 2020
Merged
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

/kind bug
/priority critical-urgent
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, liggitt, nolancon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.18 milestone Mar 5, 2020
@nolancon
Copy link
Author

nolancon commented Mar 5, 2020

/test pull-kubernetes-e2e-kind

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

/retest

@vpickard
Copy link
Contributor

vpickard commented Mar 5, 2020 •
edited

@liggitt Can you manually trigger the failing ga conformance test, or do we have to wait for the next CI job to run?

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

/test pull-kubernetes-conformance-kind-ga-only

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020 •
edited

^ is serial and takes 90 minutes to run but if it gets past the cluster startup phase we'll know this resolved things

@vpickard
Copy link
Contributor

vpickard commented Mar 5, 2020

Thanks, can you share a link to the job

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/88857/pull-kubernetes-conformance-kind-ga-only/1235613995415638016

@nolancon
Copy link
Author

nolancon commented Mar 5, 2020

/retest

1 similar comment
@nolancon
Copy link
Author

nolancon commented Mar 5, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

e2e flake is #88861

@nolancon
Copy link
Author

nolancon commented Mar 5, 2020

/test pull-kubernetes-kubemark-e2e-gce-big

@nolancon
Copy link
Author

nolancon commented Mar 5, 2020

/test pull-kubernetes-e2e-gce

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

ga-only job passed: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/88857/pull-kubernetes-conformance-kind-ga-only/1235613995415638016

@nolancon
Copy link
Author

nolancon commented Mar 5, 2020

ga-only job passed: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/88857/pull-kubernetes-conformance-kind-ga-only/1235613995415638016

Thanks for the help @liggitt, now just to get past these flaking tests.

@liggitt liggitt mentioned this pull request Mar 5, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

#86318 flake

/test pull-kubernetes-e2e-gce

@vpickard
Copy link
Contributor

vpickard commented Mar 5, 2020

/test pull-kubernetes-kubemark-e2e-gce-big

@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

whew. all green and in the merge queue.

@k8s-ci-robot k8s-ci-robot merged commit ce01a9b into kubernetes:master Mar 6, 2020
@liggitt liggitt mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

CPU manager allocation NPE in GA-only clusters
5 participants
@nolancon @klueska @liggitt @k8s-ci-robot @vpickard