Add event generation when create/delete of balancers fails. #8887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partial fix for #8760 - we should open another bug to report it in stats.loadBalancer.condition |
| @@ -206,6 +215,7 @@ func (s *ServiceController) processDelta(delta *cache.Delta) (error, bool) { | |||
| case cache.Sync: | |||
| err, retry := s.createLoadBalancerIfNeeded(namespacedName, service, cachedService.service) | |||
| if err != nil { | |||
| s.eventRecorder.Event(service, "creating balancer failed", err.Error()) | |||
There was a problem hiding this comment.
Nit (because I believe these become part of our contract?): balancer -> loadbalancer ?
|
Two nits if events are considered part of our contract (i.e. difficult to change). LGTM though. Thank you for fixing - I was looking at fixing as part of #8892, but then saw you had implemented this already :-) |
justinsb
added a commit
to justinsb/kubernetes
that referenced
this pull request
May 28, 2015
Once kubernetes#8887 merges this should show errors in load balancer creation. Even before then, it may show another error. Bug kubernetes#8892
This was referenced May 28, 2015
|
@justinsb comments addressed, please re-check. Thanks! |
|
LGTM - thanks again! |
brendandburns
added
the
lgtm
rjnagal
added a commit
that referenced
this pull request
May 29, 2015
Add event generation when create/delete of balancers fails.
justinsb
added a commit
to justinsb/kubernetes
that referenced
this pull request
Jul 26, 2015
Once kubernetes#8887 merges this should show errors in load balancer creation. Even before then, it may show another error. Bug kubernetes#8892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8760