Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: Skip building manifest list if no image was pushed #88892

Merged
merged 1 commit into from Mar 6, 2020
Merged

test images: Skip building manifest list if no image was pushed #88892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/images/image-util.sh
View file
Open in desktop
Expand Up @@ -204,7 +204,13 @@ push() {
# Windows images into the manifest list.
if test -z "${REMOTE_DOCKER_URL:-}" && printf "%s\n" "$os_archs" | grep -q '^windows'; then
echo "Skipping pushing the image '${image}' for Windows. REMOTE_DOCKER_URL_\${os_version} should be set, containing the URL to a Windows docker daemon."
os_archs=$(printf "%s\n" "$os_archs" | grep -v "^windows")
os_archs=$(printf "%s\n" "$os_archs" | grep -v "^windows" || true)
fi

if test -z "${os_archs}"; then
# this can happen for Windows-only images if they have been skipped entirely.
echo "No image for the manifest list. Skipping ${image}."
return
fi

kube::util::ensure-gnu-sed
Expand Down Expand Up @@ -238,7 +244,7 @@ push() {
}

# This function is for building AND pushing images. Useful if ${WHAT} is "all-conformance".
# This will allow images to be pushed immediately after they've been pushed.
# This will allow images to be pushed immediately after they've been built.
build_and_push() {
image=$1
build "${image}"
Expand Down