-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for shared burstable pod resource limits #88899
Conversation
Hi @liorokman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR replaces #88722. (I made the mistake of merging instead of rebasing) |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
You should open the KEP as a PR to kubernetes/enhancements first so we can discuss. I would also highly recommend putting this on the agenda for the weekly sig-node meeting. /hold |
Here's the PR: kubernetes/enhancements#1592
How do I do this? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
c610dd9
to
05873bb
Compare
Implement the feature as outlined in the KEP
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liorokman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a very useful feature, looking forward to see this feature get released! |
@liorokman: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enhances the
Burstable
QoS level for pods by allowing deployments to define resource limits which are enforced on the Pod level, rather than only on the Container level.While the current
Burstable
QoS level allows creating a resource limit for each containers, it doesn't allow defining a pod with an enforced resource limit that can be shared between multiple containers. Enforcing a limit on the pod level means that developers can decide the overall amount of resources assigned to a pod without having to micro-manage the split of resources between containers in the pod. This allows supporting a more dynamic range of applications.This PR offers this new functionality as an opt-in feature. In order to use it, the
PodSpec
must set theShareBurstableLimits
to true. When this is done, the pod level cgroup is set to the sum of all the container limits which were actually defined. Pods can then:Which issue(s) this PR fixes:
Fixes #84340 , #87365, #60834
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: