Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: ARG instructions should be first #88903

Merged
merged 1 commit into from Mar 10, 2020
Merged

test images: ARG instructions should be first #88903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion test/images/node-perf/npb-ep/Dockerfile
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@ RUN make EP CLASS=D
# main container in the second build stage.
RUN mkdir -p /lib-copy && find /usr/lib -name "*.so.*" -exec cp {} /lib-copy \;

ARG BASEIMAGE
FROM $BASEIMAGE

COPY --from=build_node_perf_npb_ep /NPB3.3.1/NPB3.3-OMP/bin/ep.D.x /
Expand Down
1 change: 0 additions & 1 deletion test/images/node-perf/npb-is/Dockerfile
View file
Open in desktop
Expand Up @@ -36,7 +36,6 @@ RUN make IS CLASS=D
# main container in the second build stage.
RUN mkdir -p /lib-copy && find /usr/lib -name "*.so.*" -exec cp {} /lib-copy \;

ARG BASEIMAGE
FROM $BASEIMAGE

COPY --from=build_node_perf_npb_is /NPB3.3.1/NPB3.3-OMP/bin/is.D.x /
Expand Down
2 changes: 1 addition & 1 deletion test/images/sample-apiserver/Dockerfile
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG BASEIMAGE
FROM us.gcr.io/k8s-artifacts-prod/build-image/kube-cross:v1.13.8-1 as build_k8s_1_17_sample_apiserver

ENV GOPATH /go
Expand All @@ -32,7 +33,6 @@ RUN GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=BASEARCH go get k8s.io/sample
# we can copy it out from this throw away container image from a standard location
RUN find /go/bin -name sample-apiserver -exec cp {} / \;

ARG BASEIMAGE
FROM $BASEIMAGE
COPY --from=build_k8s_1_17_sample_apiserver /sample-apiserver /sample-apiserver

Expand Down