Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait until /metrics are ready on e2e test #89048

Merged
merged 1 commit into from
Mar 12, 2020
Merged

wait until /metrics are ready on e2e test #89048

merged 1 commit into from
Mar 12, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 11, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:

Some e2e tests depend on the controller-manager to expose metrics
on the path /metrics.

It may happen that when the test runs, the pod is not available or the
URL not ready, causing it to fail.

Previously, the test were waiting until the pod was running, but we
need to wait until the /metrics URL is ready.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@aojea
wait until /metrics are ready on e2e test
4361f8f 
Some e2e tests depend on the controller-manager to expose metrics
on the path /metrics.

It may happen that when the test runs, the pod is not available or the
URL not ready, causing it to fail.

Previously, the test were waiting until the pod was running, but we
need to wait until the /metrics URL is ready.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2020
@aojea
Copy link
Member Author

aojea commented Mar 11, 2020

xref #86318
/assign @liggitt
all the credit to Jordan :)
#86318 (comment)

@liggitt
Copy link
Member

liggitt commented Mar 11, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Mar 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@aojea
Copy link
Member Author

aojea commented Mar 11, 2020 •
edited

/retest
kind failures

[sig-storage] ConfigMap binary data should be reflected in volume [NodeConformance] [Conformance] expand_more4m57s | [sig-storage] ConfigMap binary data should be reflected in volume [NodeConformance] [Conformance] expand_more | 4m57s

Integration test TestStressingCascadingDeletion 🤔

@liggitt
Copy link
Member

liggitt commented Mar 11, 2020

/retest

@aojea
Copy link
Member Author

aojea commented Mar 11, 2020 •
edited

/retest

[sig-cli] Kubectl client Simple pod should support inline execution and attach expand_less

@aojea
Copy link
Member Author

aojea commented Mar 11, 2020

/retest
kind job wasn't able to run

@spiffxp
Copy link
Member

spiffxp commented Mar 12, 2020

/milestone v1.18
fixes a frequently occurring test flake

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 12, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d8077e9 into kubernetes:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @liggitt @k8s-ci-robot @spiffxp @fejta-bot