Fix AWS volumes #8906
Merged
Fix AWS volumes #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
force-pushed
the
aws_volume_fixes
branch
3 times, most recently
from
05e4461
to
97a312f
Compare
thockin
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Edited to split into logically separate PRs)
Fix an error introduced during the switch to aws-sdk-go (aws-sdk-go is much stricter about "" vs nil than goamz.)
We're also moving the interfaces in here to be much closer to a direct-wrapper of the underlying API, now that we have a more consistent library.