Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selfLinks in test examples to v1beta3 #8909

Merged
merged 1 commit into from May 28, 2015

Conversation

wojtek-t
Copy link
Member

No description provided.

@wojtek-t
Copy link
Member Author

cc @nikhiljindal

@@ -4,7 +4,7 @@
"metadata": {
"name": "elasticsearch-logging-controller",
"namespace": "default",
"selfLink": "/api/v1beta1/replicationControllers/elasticsearch-logging-controller?namespace=default",
"selfLink": "/api/v1beta3/namespaces/default/replicationControllers/elasticsearch-logging-controller",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replicationcontrollers should be all lowercase

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2015
@bgrant0607
Copy link
Member

LGTM, thanks

thockin added a commit that referenced this pull request May 28, 2015
Fix selfLinks in test examples to v1beta3
@thockin thockin merged commit 1087c12 into kubernetes:master May 28, 2015
@wojtek-t wojtek-t deleted the fix_example_selflinks branch July 16, 2015 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants