move runonce from flag to config #89128

vincent178 · 2020-03-14T23:49:31Z

What type of PR is this?
/kind api-change

What this PR does / why we need it:

part of Migrate Kubelet flags to config #86843

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Yes. It exposes the RunOnce option in Kubelet's ComponentConfig API.

Kubelet's --runonce option is now also available in Kubelet's config file as `runOnce`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Usage]: https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/

k8s-ci-robot · 2020-03-14T23:49:35Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-03-14T23:49:39Z

Welcome @vincent178!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-03-14T23:49:40Z

Hi @vincent178. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mtaufen

Thanks @vincent178! Left some comments.

mtaufen · 2020-03-16T21:52:26Z

staging/src/k8s.io/kubelet/config/v1beta1/types.go

+	// run those in addition to the pods specified by static pod files, and exit.
+	// Default: false
+	// +optional
+	RunOnce bool


I think the test you mentioned on Slack may be failing because this doesn't have the json:"runOnce,omitempty" tag.

mtaufen · 2020-03-16T21:54:23Z

staging/src/k8s.io/kubelet/config/v1beta1/types.go

+	// TODO(mtaufen): It is increasingly looking like nobody actually uses the
+	//                Kubelet's runonce mode anymore, so it may be a candidate
+	//                for deprecation and removal.
+	// If runOnce is true, the Kubelet will check the API server once for pods,


Can you format this comment like the others (start with the field name, as it would appear in JSON)?

// runOnce causes the Kubelet to check the API server once for pods, // run those in addition to the pods specified by static pod files, and exit. // Default: false // +optional

mtaufen · 2020-03-16T21:55:13Z

staging/src/k8s.io/kubelet/config/v1beta1/types.go

@@ -490,6 +490,14 @@ type KubeletConfiguration struct {
 	// Default: "/etc/resolv.conf"
 	// +optional
 	ResolverConfig string `json:"resolvConf,omitempty"`
+	// TODO(mtaufen): It is increasingly looking like nobody actually uses the


You can remove this comment :). If we ever decide to remove it, it would best be done as a v2 API in the distant future.

mtaufen · 2020-03-16T21:55:44Z

pkg/kubelet/apis/config/types.go

@@ -238,6 +238,12 @@ type KubeletConfiguration struct {
 	// ResolverConfig is the resolver configuration file used as the basis
 	// for the container DNS resolution configuration.
 	ResolverConfig string
+	// TODO(mtaufen): It is increasingly looking like nobody actually uses the


Ditto for removing this TODO comment.

mtaufen

Thanks, one additional comment.

Also, if you haven't seen it yet, there are some instructions here: https://docs.google.com/document/d/10Kz__miCWEOekC6WnsUdxYWSLrf-t1AkHHpZN57ei5c/edit#heading=h.mupqgfuyjwnm

mtaufen · 2020-03-24T20:25:53Z

pkg/kubelet/apis/config/types.go

@@ -238,6 +238,9 @@ type KubeletConfiguration struct {
 	// ResolverConfig is the resolver configuration file used as the basis
 	// for the container DNS resolution configuration.
 	ResolverConfig string
+	// If runOnce is true, the Kubelet will check the API server once for pods,


Can you update this comment to match the one on the public type (just the text part, not the default or optional)?

// RunOnce causes the Kubelet to check the API server once for pods, // run those in addition to the pods specified by static pod files, and exit.

mtaufen · 2020-03-24T21:52:12Z

Do you also need to update k8s.io/kubernetes/pkg/kubelet/apis/config/helpers_test.go to include RunOnce in the list of kubeletConfigurationNonPathFieldPaths?

mtaufen · 2020-04-10T23:09:29Z

/ok-to-test

mtaufen · 2020-04-10T23:19:01Z

Sorry for the delay @vincent178. I updated the PR description with some additional details and removed the [WIP] from the title, as this looks good.

/lgtm

mtaufen · 2020-04-10T23:19:21Z

/priority important-longterm

mtaufen · 2020-04-10T23:22:27Z

/approve

mtaufen · 2020-04-10T23:23:08Z

/assign @liggitt
for overall approval

fejta-bot · 2020-04-10T23:40:43Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

vincent178 · 2020-04-11T01:25:55Z

/assign @lavalamp

liggitt · 2020-04-13T18:07:21Z

go ahead and squash this to a single commit, then lgtm

vincent178 · 2020-04-13T22:02:49Z

@liggitt @mtaufen squashed to single commit now, would you mind take another look? Thanks

vincent178 · 2020-04-13T23:14:13Z

/retest

mtaufen · 2020-04-16T19:06:57Z

/lgtm

liggitt · 2020-04-23T16:33:16Z

/approve

k8s-ci-robot · 2020-04-23T16:35:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mtaufen, vincent178

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kubelet/OWNERS~~ [liggitt]
~~pkg/kubelet/apis/config/OWNERS~~ [liggitt,mtaufen]
~~staging/src/k8s.io/kubelet/config/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vincent178 · 2020-04-23T20:57:00Z

/retest

vincent178 · 2020-04-23T21:29:42Z

/retest

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 14, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2020

vincent178 changed the title ~~move runonce from flag to config~~ [WIP] move runonce from flag to config Mar 14, 2020

k8s-ci-robot requested review from krmayankk and resouer March 14, 2020 23:50

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 15, 2020

mtaufen reviewed Mar 16, 2020

View reviewed changes

vincent178 requested a review from mtaufen March 19, 2020 22:38

mtaufen reviewed Mar 24, 2020

View reviewed changes

vincent178 force-pushed the move-runonce-kubeletconfiguration branch from 6ddec8b to 343fba6 Compare March 24, 2020 22:20

mtaufen changed the title ~~[WIP] move runonce from flag to config~~ move runonce from flag to config Apr 10, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2020

k8s-ci-robot assigned mtaufen Apr 10, 2020

k8s-ci-robot assigned liggitt Apr 10, 2020

k8s-ci-robot assigned lavalamp Apr 11, 2020

move runonce from flag to config

745b742

vincent178 force-pushed the move-runonce-kubeletconfiguration branch from 343fba6 to 745b742 Compare April 13, 2020 22:01

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020

k8s-ci-robot merged commit 30cefca into kubernetes:master Apr 24, 2020

k8s-ci-robot added this to the v1.19 milestone Apr 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move runonce from flag to config #89128

move runonce from flag to config #89128

vincent178 commented Mar 14, 2020 •

edited by mtaufen

Loading

k8s-ci-robot commented Mar 14, 2020

k8s-ci-robot commented Mar 14, 2020

k8s-ci-robot commented Mar 14, 2020

mtaufen left a comment

mtaufen Mar 16, 2020

mtaufen Mar 16, 2020

mtaufen Mar 16, 2020

mtaufen Mar 16, 2020

mtaufen left a comment •

edited

Loading

mtaufen Mar 24, 2020

mtaufen commented Mar 24, 2020

mtaufen commented Apr 10, 2020

mtaufen commented Apr 10, 2020 •

edited

Loading

mtaufen commented Apr 10, 2020

mtaufen commented Apr 10, 2020

mtaufen commented Apr 10, 2020

fejta-bot commented Apr 10, 2020

vincent178 commented Apr 11, 2020

liggitt commented Apr 13, 2020

vincent178 commented Apr 13, 2020

vincent178 commented Apr 13, 2020

mtaufen commented Apr 16, 2020

liggitt commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

vincent178 commented Apr 23, 2020

vincent178 commented Apr 23, 2020

move runonce from flag to config #89128

move runonce from flag to config #89128

Conversation

vincent178 commented Mar 14, 2020 • edited by mtaufen Loading

k8s-ci-robot commented Mar 14, 2020

k8s-ci-robot commented Mar 14, 2020

k8s-ci-robot commented Mar 14, 2020

mtaufen left a comment

Choose a reason for hiding this comment

mtaufen Mar 16, 2020

Choose a reason for hiding this comment

mtaufen Mar 16, 2020

Choose a reason for hiding this comment

mtaufen Mar 16, 2020

Choose a reason for hiding this comment

mtaufen Mar 16, 2020

Choose a reason for hiding this comment

mtaufen left a comment • edited Loading

Choose a reason for hiding this comment

mtaufen Mar 24, 2020

Choose a reason for hiding this comment

mtaufen commented Mar 24, 2020

mtaufen commented Apr 10, 2020

mtaufen commented Apr 10, 2020 • edited Loading

mtaufen commented Apr 10, 2020

mtaufen commented Apr 10, 2020

mtaufen commented Apr 10, 2020

fejta-bot commented Apr 10, 2020

vincent178 commented Apr 11, 2020

liggitt commented Apr 13, 2020

vincent178 commented Apr 13, 2020

vincent178 commented Apr 13, 2020

mtaufen commented Apr 16, 2020

liggitt commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

vincent178 commented Apr 23, 2020

vincent178 commented Apr 23, 2020

vincent178 commented Mar 14, 2020 •

edited by mtaufen

Loading

mtaufen left a comment •

edited

Loading

mtaufen commented Apr 10, 2020 •

edited

Loading