Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comments #89149

Merged
merged 1 commit into from Mar 19, 2020
Merged

Fix comments #89149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/scheduler/core/generic_scheduler.go
View file
Open in desktop
Expand Up @@ -108,7 +108,7 @@ type ScheduleAlgorithm interface {
// It returns the node where preemption happened, a list of preempted pods, a
// list of pods whose nominated node name should be removed, and error if any.
Preempt(context.Context, *profile.Profile, *framework.CycleState, *v1.Pod, error) (selectedNode *v1.Node, preemptedPods []*v1.Pod, cleanupNominatedPods []*v1.Pod, err error)
// Prioritizers returns a slice of priority config. This is exposed for
// Extenders returns a slice of extender config. This is exposed for
// testing.
Extenders() []SchedulerExtender
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/scheduler/framework/plugins/legacy_registry.go
View file
Open in desktop
Expand Up @@ -420,7 +420,7 @@ func NewLegacyRegistry() *LegacyRegistry {
})

// The following two features are the last ones to be supported as predicate/priority.
// Once they graduate to GA, there will be no more checking for featue gates here.
// Once they graduate to GA, there will be no more checking for feature gates here.
// Only register EvenPodsSpread predicate & priority if the feature is enabled
if utilfeature.DefaultFeatureGate.Enabled(features.EvenPodsSpread) {
klog.Infof("Registering EvenPodsSpread predicate and priority function")
Expand Down