Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default etcd server to 3.4.4 in k8s v1.19 #89214

Merged
merged 1 commit into from Mar 26, 2020
Merged

Update default etcd server to 3.4.4 in k8s v1.19 #89214

merged 1 commit into from Mar 26, 2020

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Mar 18, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We are updating etcd client version to 3.4.4 in #89169. This PR updates the default etcd server version to 3.4.4.

Which issue(s) this PR fixes:
Fixes #89154

Does this PR introduce a user-facing change?:

Update default etcd server version to 3.4.4

/sig api-machinery
/area etcd

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jingyih. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 18, 2020
@jingyih
Copy link
Contributor Author

jingyih commented Mar 18, 2020 •
edited

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@jingyih
Copy link
Contributor Author

jingyih commented Mar 18, 2020

/cc @dims @wojtek-t @wenjiaswe

@jingyih
Copy link
Contributor Author

jingyih commented Mar 18, 2020

@listx Previously we push etcd related images to gcr.io/k8s-image-staging and then promote them to gcr.io/google-containers. Can we still use this process?

@wojtek-t
Copy link
Member

@listx Previously we push etcd related images to gcr.io/k8s-image-staging and then promote them to gcr.io/google-containers. Can we still use this process?

Yes

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2020
@neolit123
Copy link
Member

/approve

@neolit123
Copy link
Member

thanks for sending the PR for this @jingyih

@RA489
Copy link

RA489 commented Mar 19, 2020

/retest

@jingyih jingyih mentioned this pull request Mar 19, 2020
Closed
@jpbetz
Copy link
Contributor

jpbetz commented Mar 19, 2020

Changes look right. Will wait for image push before lgtm.

@jingyih
Copy link
Contributor Author

jingyih commented Mar 23, 2020

Images are promoted to k8s.gcr.io.

/retest

@jingyih
Copy link
Contributor Author

jingyih commented Mar 24, 2020

/retest

@jingyih jingyih changed the title [WIP] Update default etcd server to 3.4.4 in k8s v1.19 Update default etcd server to 3.4.4 in k8s v1.19 Mar 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2020
@jingyih
Copy link
Contributor Author

jingyih commented Mar 24, 2020

All tests passed. PTAL.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
wojtek-t
wojtek-t reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

cluster/images/etcd/Makefile Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyih, neolit123, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@jingyih
Copy link
Contributor Author

jingyih commented Mar 25, 2020 •
edited

Changes look right. Will wait for image push before lgtm.

@jpbetz Images are pushed. Could you lgtm?

@dims
Copy link
Member

dims commented Mar 26, 2020 •
edited

@jpbetz @jingyih @wojtek-t is it too early to switch to etcd 3.4.5?

if we did, we could do the hasleader stuff for watch? (someone was asking about it in #89488)

@dims
Copy link
Member

dims commented Mar 26, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@jpbetz
Copy link
Contributor

jpbetz commented Mar 26, 2020

/lgtm

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@jingyih
Copy link
Contributor Author

jingyih commented Mar 26, 2020

@jpbetz @jingyih @wojtek-t is it too early to switch to etcd 3.4.5?

if we did, we could do the hasleader stuff for watch? (someone was asking about it in #89488)

If we are going to use WithRequireLeader in our codebase (more context in #89488). We should pick up the related bug fix in etcd v3.4.5.

@k8s-ci-robot k8s-ci-robot merged commit 295b53f into kubernetes:master Mar 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 26, 2020
@dims dims mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@cheftako cheftako Awaiting requested review from cheftako

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@dims dims Awaiting requested review from dims

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@dims dims

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/etcd area/kubeadm area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Update to etcd 3.4.4 in Kubernetes 1.19 release
8 participants
@jingyih @k8s-ci-robot @wojtek-t @neolit123 @RA489 @jpbetz @dims @fejta-bot