Update ContainerState.Termination to ContainerState.Terminated #8923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this for me. :-) |
|
LGTM |
bgrant0607
added
the
lgtm
|
needs rebase |
caesarxuchao
force-pushed
the
TerminationToTerminated
branch
from
b38213c
to
6ac41ac
Compare
|
Rebased. Let's see if it still passess all tests. |
|
Negative on CI |
caesarxuchao
force-pushed
the
TerminationToTerminated
branch
from
6ac41ac
to
813b7a8
Compare
|
It's because the Goimports on my machine randomly removes actual dependencies. I can't fix it. Have you ever met similar problems? |
|
Fix your GOPATH On Thu, May 28, 2015 at 4:33 PM, Chao Xu notifications@github.com wrote:
|
caesarxuchao
force-pushed
the
TerminationToTerminated
branch
from
813b7a8
to
671ff07
Compare
added 2 commits
May 28, 2015 17:18
…/api/types.go and pkg/api/v1/types.go
caesarxuchao
force-pushed
the
TerminationToTerminated
branch
from
671ff07
to
9f5e0b6
Compare
|
Shippable is green |
rjnagal
added a commit
that referenced
this pull request
May 29, 2015
Update ContainerState.Termination to ContainerState.Terminated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ContainerState.Termination to ContainerState.Terminated in pkg/api/types.go and pkg/api/v1/types.go
#7018 #6979
@krousey @bgrant0607