Fix help msg for kubectl get cmd #8925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
I'm 50/50 on this. I'm generally in favor of autogenerating stuff, but this also seems a bit overkill for keeping a help string up to date, given that we don't add resources that often. In any case, I don't think this is worth spending time on right now. Let's just update the const help string and look at doing something smarter post v1.0. |
|
Ok I will just update the help string |
|
done |
j3ffml
added
lgtm
|
Negative on CI |
|
I think this just needs rebase to pick up #8965. |
|
rebased and ready |
rjnagal
added a commit
that referenced
this pull request
May 29, 2015
Fix help msg for kubectl get cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs to #7842
I am not sure if this is the right way on solving this. Can someone comment?
(btw, I didn't regenerated the docs. It is just for initializing a discussion. Don't merge)
/cc @mbforbes