Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use e2epod.WaitForPodNotFoundInNamespace directly #89323

Merged
merged 1 commit into from
Mar 22, 2020
Merged

use e2epod.WaitForPodNotFoundInNamespace directly #89323

merged 1 commit into from
Mar 22, 2020

Conversation

tanjunchen
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

WaitForPodNotFound is wrapper functions for e2epod package, and they made an invalid dependency to sub e2e framework from the core framework.

So we can use e2epod.WaitForPodNotFoundInNamespace to remove invalid dependency.

/cc @oomichi
for review . Thank you very much.

Which issue(s) this PR fixes:

ref:#81245

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 21, 2020
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: The label(s) kind/ cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

WaitForPodNotFound is wrapper functions for e2epod package, and they made an invalid dependency to sub e2e framework from the core framework.

So we can use e2epod.WaitForPodNotFoundInNamespace to remove invalid dependency.

/cc @oomichi
for review . Thank you very much.

Which issue(s) this PR fixes:

ref:#81245

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2020
@tanjunchen
Copy link
Member Author

/assign @andrewsykim

@oomichi
Copy link
Member

oomichi commented Mar 22, 2020

/test pull-kubernetes-e2e-gce
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2020
@tanjunchen
Copy link
Member Author

/kind cleanup
/priority backlog
/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit c3d483b into kubernetes:master Mar 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 22, 2020
@tanjunchen tanjunchen deleted the remove-invalid-dependency-waitForPod-001 branch March 22, 2020 05:10
@benmoss benmoss mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanjunchen @k8s-ci-robot @oomichi @andrewsykim