New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI script for listing untested conformance behaviors #89393
Conversation
/assign @johnbelamaric |
@@ -63,23 +65,6 @@ type frame struct { | |||
Line int | |||
} | |||
|
|||
type conformanceData struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this to a separate library to avoid duplication
Thanks @Jefftree. A couple thoughts come to mind:
Along these lines, we need to update the KEP to reflect our desired end state better. That is, we want tooling that eliminates the need for |
Sure, will make the change. I'd prefer committing smaller pieces and adding more functionality as we need them, so updating the KEP is definitely helpful.
|
I am ok with using conformance.yaml for now. |
Oh, and I meant that in general it's a single file everyone has to regenerate when they promote tests, so it creates conflicts in PRs, not that it conflicts with this code. |
892fed9
to
0230c25
Compare
@Jefftree: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Awesome, thanks. As we define the full set of commands for /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, johnbelamaric The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add CLI script for listing conformance behaviors that have not been covered by tests.
Usage:
go run test/conformance/kubetestlink/kubetestlink.go
Since we don't have the full list of behaviors yet I'm still not sure about all the features we want to include with this CLI utility.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: