test images: uses nanoserver #89425
Merged
test images: uses nanoserver #89425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/dependency
|
/cc @adelina-t |
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
from
bf65ff3
to
1e7d06e
Compare
k8s-ci-robot
removed
the
needs-rebase
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
2 times, most recently
from
6481c6c
to
5fcc809
Compare
k8s-ci-robot
added
the
needs-rebase
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
from
5fcc809
to
57317aa
Compare
k8s-ci-robot
removed
the
needs-rebase
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
2 times, most recently
from
60a74f3
to
68fe365
Compare
k8s-ci-robot
added
the
needs-rebase
spiffxp
reviewed
Sep 16, 2020
| @@ -17,40 +17,131 @@ limitations under the License. | |||
| package dns | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "os/exec" | |||
| "fmt" | |||
There was a problem hiding this comment.
line unrelated
Is there any particular reason we don't have // +build windows as line 1 of this file?
There was a problem hiding this comment.
Sure, it felt redundant, we were already relying on the file name suffix for that (conditional compilation can also be done through filename suffix). Added that line now.
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
from
b3f4d89
to
ed00653
Compare
|
needs rebase |
k8s-ci-robot
added
the
needs-rebase
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
from
ed00653
to
732705b
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
liggitt
reviewed
Sep 18, 2020
Using Windows nanoserver container images as a base instead of the current Windows servercore image will reduce the image size by about ~10x. However, the nanoserver image lacks several things we need: - netapi32.dll - powershell - certain powershell commands - chocolatey cannot be used When building the nanoserver images, we are going to use a Windows servercore helper, in which we are going to install the necessary dependencies, and then copy them over to our nanoserver image, including necessary DLLs. Other notable changes include: - switch from wget to curl (wget was a powershell alias). - implement in code getting the DNS suffix list and DNS server list. - reimplement getting file permissions for mounttest.
claudiubelu
force-pushed
the
test-images/switch-to-nanoserver
branch
from
732705b
to
46c820e
Compare
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@claudiubelu: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-kubernetes-e2e-azure-disk-windows |
|
Can the /lgtm be reapplied? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/sig testing
/sig windows
What this PR does / why we need it:
Using Windows nanoserver container images as a base instead of the current Windows servercore image will reduce the image size by about ~10x.
However, the nanoserver image lacks several things we need:
When building the nanoserver images, we are going to use a Windows servercore helper, in which we are going to install the necessary dependencies, and then copy them over to our nanoserver image, including necessary DLLs.
Other notable changes include:
Which issue(s) this PR fixes:
Partially Fixes #77268
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: