Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Immutable Secrets/ConfigMaps to Beta #89594

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Promote Immutable Secrets/ConfigMaps to Beta #89594

merged 2 commits into from
Apr 25, 2020

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Mar 27, 2020 •
edited
Loading

Ref kubernetes/enhancements#1412

Promote Immutable Secrets/ConfigMaps feature to Beta and enable the feature by default.
This allows to set `Immutable` field in Secrets or ConfigMap object to mark their contents as immutable.

As stated in the KEP, graduation criteria is extending scalability test to cover this feature. The test is being extended in: kubernetes/perf-tests#1146

We've run 5k-tests with this PR against this updated test and they seem to work great (we can't merge that change now, because it requires this PR to pass - i.e. the immutable secrets/configmaps feature is necessary to have the test passing).

/kind feature
/priority important-soon

@wojtek-t wojtek-t self-assigned this Mar 27, 2020
@wojtek-t
Copy link
Member Author

@k8s-ci-robot - ping?

@wojtek-t wojtek-t closed this Mar 27, 2020
@wojtek-t wojtek-t reopened this Mar 27, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 27, 2020
@wojtek-t wojtek-t added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 27, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 27, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2020
@wojtek-t
Copy link
Member Author

/retest

@wojtek-t wojtek-t changed the title Promote Immutable Secrets/ConfigMaps to Beta [WIP] Promote Immutable Secrets/ConfigMaps to Beta Apr 8, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2020
@wojtek-t wojtek-t changed the title [WIP] Promote Immutable Secrets/ConfigMaps to Beta Promote Immutable Secrets/ConfigMaps to Beta Apr 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
@wojtek-t wojtek-t assigned saad-ali and msau42 and unassigned wojtek-t and msau42 Apr 24, 2020
@wojtek-t
Copy link
Member Author

wojtek-t commented Apr 24, 2020 •
edited
Loading

@saad-ali @msau42 - the API-review part of this PR is kind-of trivial, but before I ask for final approval, I would like to get the SIG leads buy-in for the promotion to beta.
Adding you explicitly since you were involved in Alpha stage of the feature.

@msau42
Copy link
Member

msau42 commented Apr 24, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
@wojtek-t
Copy link
Member Author

Thanks a lot for super quick reaction @msau42 !

For API review (given Tim already made the API review for alpha).
/assign @thockin

thockin
thockin reviewed Apr 25, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 52ba6dc into kubernetes:master Apr 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 25, 2020
@wojtek-t wojtek-t mentioned this pull request Apr 27, 2020
Merged
@wojtek-t wojtek-t mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

Assignees

@thockin thockin

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wojtek-t @fejta-bot @msau42 @k8s-ci-robot @thockin @saad-ali