Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event about Node when cannot assign CIDR. #8960

Merged
merged 1 commit into from
May 29, 2015
Merged

Add event about Node when cannot assign CIDR. #8960

merged 1 commit into from
May 29, 2015

Conversation

erictune
Copy link
Member

Closes #8506

@dchen1107 dchen1107 self-assigned this May 28, 2015
@dchen1107
Copy link
Member

LGTM except one nit: I notice that there is another event generated at https://github.com/erictune/kubernetes/blob/nodectrlevent/pkg/cloudprovider/nodecontroller/nodecontroller.go#L392

            nc.recordNodeEvent(node, "NodeNotReady")

Can we consolidate the event format here?

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2015
@roberthbailey
Copy link
Contributor

Thanks @erictune. :)

rjnagal added a commit that referenced this pull request May 29, 2015
@rjnagal
Merge pull request #8960 from erictune/nodectrlevent
9184ccf 
Add event about Node when cannot assign CIDR.
@rjnagal rjnagal merged commit 9184ccf into kubernetes:master May 29, 2015
@erictune erictune deleted the nodectrlevent branch July 28, 2015 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fire an event when CIDRs can't be assigned to nodes
5 participants
@erictune @dchen1107 @roberthbailey @googlebot @rjnagal