Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow list-resources.sh to continue if a resource fails to list #89664

Merged

Commits on Mar 30, 2020

  1. Allow list-resources.sh to continue if a resource fails to list

    The list-resources.sh script is used solely by our CI, specifically
    kubernetes/test-infra/kubetest with the --check-leaked-resources
    flag. Currently if a single resource fails to list, we fail the entire
    job.
    
    I think this is too brittle. A review of previous issues on
    kubernetes/kubernetes that relate to failure of this script shows that
    the issues usually resolve themselves, or would be caught by the diff
    of before/after.
    
    Let's instead allow the script to continue listing all resources,
    and let kubetest's resource diff fail the job.
    spiffxp committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5265319 View commit details
    Browse the repository at this point in the history