Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hcsshim to latest - v0.8.9 #89710

Merged
merged 1 commit into from May 28, 2020
Merged

Update hcsshim to latest - v0.8.9 #89710

merged 1 commit into from May 28, 2020

Conversation

dims
Copy link
Member

@dims dims commented Apr 1, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Use latest release instead of a random SHA. This new version of hcsshim also breaks the recursive dependency between the two projects

Which issue(s) this PR fixes:

Fixes #87420

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from cheftako, thockin and a team April 1, 2020 01:51
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 1, 2020
@dims dims mentioned this pull request Apr 1, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Apr 1, 2020

mechanics lgtm

@liggitt
Copy link
Member

liggitt commented Apr 1, 2020

filed #89712 for flake
/retest

@cheftako
Copy link
Member

cheftako commented Apr 1, 2020

Change so far seems fine to me.

@dims dims closed this May 1, 2020
@dims dims reopened this May 19, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2020
@dims
Update hcsshim to v0.8.9
9f00e57 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-hcsshim-to-latest branch from 1c963c7 to 9f00e57 Compare May 19, 2020 23:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 19, 2020
@dims dims changed the title [WIP] Update hcsshim to latest Update hcsshim to latest May 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2020
@dims dims changed the title Update hcsshim to latest Update hcsshim to latest - v0.8.9 May 19, 2020
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 20, 2020
@dims
Copy link
Member Author

dims commented May 20, 2020 •
edited

cc @dcantah @Betsyweber

@dims
Copy link
Member Author

dims commented May 20, 2020 •
edited

/kind cleanup
/priority important-soon
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2020
@BenTheElder
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 20, 2020
@dims
Copy link
Member Author

dims commented May 22, 2020

@benmoss @marosset @ddebroy Can one of you please approve this change from sig-windows side?

@benmoss
Copy link
Member

benmoss commented May 22, 2020

/approve

@dims
Copy link
Member Author

dims commented May 22, 2020

@liggitt this is ready for root approval. please take a look.

-- Dims

@elweb9858
Copy link
Contributor

@liggitt this is ready for root approval. please take a look.

-- Dims

bump @liggitt

@liggitt
Copy link
Member

liggitt commented May 28, 2020

/approve

@liggitt
Copy link
Member

liggitt commented May 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit e9f560d into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah left review comments

@elweb9858 elweb9858 elweb9858 approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

hcsshim has recursive dependency on kubernetes
8 participants
@dims @liggitt @cheftako @BenTheElder @benmoss @elweb9858 @k8s-ci-robot @dcantah