New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add behavior <-> conformance test linkage example for pods #89716
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,49 @@ | ||
suite: pod/spec | ||
description: Base suite for pods | ||
behaviors: | ||
- id: pod/basic-create | ||
- id: pod/spec/basic-create | ||
description: When a Pod resource is created with a single container and sufficient resources, a Pod MUST be created on a node with the specified container image. | ||
- id: pod/basic-delete | ||
- id: pod/spec/basic-delete | ||
description: When a Pod resource is delete, the Pod containers must receive a TERM signal and the Pod MUST be deleted. | ||
- id: pod/hostname | ||
- id: pod/spec/hostname | ||
description: When the hostname field is set, a container running in the Pod MUST report the hostname as the specified value. | ||
- id: pod/subdomain | ||
- id: pod/spec/subdomain | ||
description: If specified, the fully qualified Pod hostname will be "<hostname>.<subdomain>.<pod | ||
namespace>.svc.<cluster domain>". If not specified, the pod will not have a | ||
domainname at all. | ||
- id: pod/terminationGracePeriodSeconds/in-spec | ||
- id: pod/spec/terminationGracePeriodSeconds/in-spec | ||
description: When the terminationGracePeriodSeconds is specified in the spec, | ||
processes running in the Pod MUST NOT receive a hard termination signal for at | ||
least that number of seconds after a delete request. | ||
- id: pod/terminationGracePeriodSeconds/in-delete | ||
- id: pod/spec/terminationGracePeriodSeconds/in-delete | ||
description: When the terminationGracePeriodSeconds is specified in a delete request, | ||
processes running in the Pod MUST NOT receive a hard termination signal for at | ||
least that number of seconds after the delete request. | ||
- id: pod/activeDeadlineSeconds | ||
- id: pod/spec/activeDeadlineSeconds | ||
description: Optional duration in seconds the pod may be active on the node relative | ||
to StartTime before the system will actively try to mark it failed and kill | ||
associated containers. Value must be a positive integer. | ||
- id: pod/hostNetwork/true | ||
- id: pod/spec/hostNetwork/true | ||
description: When hostNetwork is set to true, the Pod MUST use the host's network | ||
namespace. | ||
- id: pod/hostNetwork/false | ||
- id: pod/spec/hostNetwork/false | ||
description: When hostNetwork is set to false, the Pod MUST NOT use the host's network | ||
namespace. | ||
- id: pod/hostPID/true | ||
- id: pod/spec/hostPID/true | ||
description: When hostPID is set to true, the Pod MUST use the host's process | ||
namespace. | ||
- id: pod/hostPID/false | ||
- id: pod/spec/hostPID/false | ||
description: When hostPID is set to false, the Pod MUST NOT use the host's process | ||
namespace. | ||
- id: pod/hostIPC/true | ||
- id: pod/spec/hostIPC/true | ||
description: When hostIPC is set to true, the Pod MUST use the host's inter-process | ||
communication namespace. | ||
- id: pod/hostIPC/false | ||
- id: pod/spec/hostIPC/false | ||
description: When hostIPC is set to false, the Pod MUST NOT use the host's inter-process | ||
communication namespace. | ||
- id: pod/spec/label/create | ||
decription: Create a Pod with a unique label. Query for the Pod with the label as selector MUST be successful. | ||
- id: pod/spec/label/patch | ||
decription: A patch request must be able to update the pod to change the value of an existing Label. Query for the Pod with the new value for the label MUST be successful. | ||
- id: pod/spec/container/resources | ||
description: Create a Pod with CPU and Memory request and limits. Pod status MUST have QOSClass set to PodQOSGuaranteed. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but does the test cover any of the specific logic around scheduling, eviction, etc. for guaranteed pods? If so we need behaviors for all of those. If not that's OK I suppose; those will show up later in sig-scheduling behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only checks for the corresponding status tags. I think the logic you mentioned should be deferred to sig-scheduling.