update statefulset pod when it is not running and has ErrImagePullBackOff error #89801

chenkaiyue · 2020-04-03T04:13:23Z

What type of PR is this?

/kind bug

What this PR does / why we need it:
update statefulset pod when it is not running and has ErrImagePullBackOff error

Which issue(s) this PR fixes:
Fixes #88896

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update statefulset pod when it is not running and has ErrImagePullBackOff error

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2020-04-03T04:13:31Z

Hi @chenkaiyue. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chenkaiyue · 2020-04-03T04:14:10Z

/assign @soltysh

ialidzhikov · 2020-04-06T19:37:12Z

pkg/controller/statefulset/stateful_set_utils.go

@@ -219,6 +219,10 @@ func isTerminating(pod *v1.Pod) bool {
 	return pod.DeletionTimestamp != nil
 }

+// isPending returns true if pod has a Phase of PodPending
+func isPending(pod *v1.Pod) bool{
+	return pod.Status.Phase != v1.PodPending


The func name is isPending and the check is pod.Status.Phase != v1.PodPending. Is it expected?

My fault, i have corrected it, THX!

chenkaiyue · 2020-04-07T02:04:26Z

@mortent @krmayankk Can you help review this pr?

chenkaiyue · 2020-04-08T04:19:39Z

@soltysh Can you help review this pr?

ialidzhikov · 2020-04-20T08:55:12Z

/kind bug

fejta-bot · 2020-07-19T09:27:18Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-08-18T10:08:36Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

silenceper · 2020-09-03T10:40:53Z

I encountered the same problem and hope to fix it soon.

pigletfly · 2020-09-08T09:23:41Z

/ok-to-test

silenceper · 2020-09-15T02:48:51Z

@chenkaiyue ci failed.

soltysh · 2020-10-02T14:30:50Z

@chenkaiyue can you update your PR?

chenkaiyue · 2020-10-11T08:36:34Z

@chenkaiyue can you update your PR?

ok

chenkaiyue · 2020-10-15T11:40:08Z

@chenkaiyue can you update your PR?

@soltysh Hi, I have updated the PR, and the CI is ok, can you help review?

soltysh

One more nit and you're good to go
/approve

soltysh · 2020-10-15T11:43:21Z

pkg/controller/statefulset/stateful_set_control.go

@@ -17,6 +17,7 @@ limitations under the License.
 package statefulset

 import (
+	"k8s.io/kubernetes/pkg/kubelet/images"


Import order: golang stdlib, 3rd party, k8s imports

Import order: golang stdlib, 3rd party, k8s imports

Thx~, I have fixed it.

chenkaiyue · 2020-10-16T02:07:30Z

@mortent @krmayankk Can you help review?

soltysh

/approve cancel
/hold
None of our controllers uses that much of insights into pod lifecycle. I think it would be good to have a broader discussion within sig-apps how to approach pod failures due to image pulls and alike in the controllers. I've added this topic for next sig-apps call on Nov 2nd.

k8s-ci-robot · 2020-10-29T12:47:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenkaiyue
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/controller/statefulset/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2020-11-28T12:59:17Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-11-28T12:59:29Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Apr 3, 2020

k8s-ci-robot requested review from krmayankk and mortent April 3, 2020 04:13

k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 3, 2020

k8s-ci-robot assigned soltysh Apr 3, 2020

ialidzhikov suggested changes Apr 6, 2020

View reviewed changes

chenkaiyue force-pushed the update-statefulset-pod-when-pending branch from 73817bd to e4d8e9c Compare April 7, 2020 02:01

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 20, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2020

soltysh mentioned this pull request Oct 2, 2020

update pending statefulset pod #94930

Closed

chenkaiyue force-pushed the update-statefulset-pod-when-pending branch from e4d8e9c to ae77366 Compare October 14, 2020 13:49

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 14, 2020

chenkaiyue force-pushed the update-statefulset-pod-when-pending branch 3 times, most recently from c6703fb to 92250c3 Compare October 14, 2020 15:30

chenkaiyue changed the title ~~update statefulset pod when pending~~ update statefulset pod's image in updateStatefulSet Oct 15, 2020

chenkaiyue force-pushed the update-statefulset-pod-when-pending branch from 92250c3 to 8691dd2 Compare October 15, 2020 10:43

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2020

chenkaiyue changed the title ~~update statefulset pod's image in updateStatefulSet~~ update image when pod is not running and has ErrImagePullBackOff error Oct 15, 2020

chenkaiyue changed the title ~~update image when pod is not running and has ErrImagePullBackOff error~~ update pod when pod is not running and has ErrImagePullBackOff error Oct 15, 2020

chenkaiyue changed the title ~~update pod when pod is not running and has ErrImagePullBackOff error~~ update statefulset pod when it is not running and has ErrImagePullBackOff error Oct 15, 2020

soltysh approved these changes Oct 15, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020

chenkaiyue force-pushed the update-statefulset-pod-when-pending branch from c8ff342 to e402042 Compare October 15, 2020 13:27

update image when pod is not running and has ErrImagePullBackOff error

e402042

soltysh reviewed Oct 29, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020

k8s-ci-robot closed this Nov 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update statefulset pod when it is not running and has ErrImagePullBackOff error #89801

update statefulset pod when it is not running and has ErrImagePullBackOff error #89801

chenkaiyue commented Apr 3, 2020 •

edited

k8s-ci-robot commented Apr 3, 2020

chenkaiyue commented Apr 3, 2020

ialidzhikov Apr 6, 2020 •

edited

chenkaiyue Apr 7, 2020

chenkaiyue commented Apr 7, 2020

chenkaiyue commented Apr 8, 2020

ialidzhikov commented Apr 20, 2020

fejta-bot commented Jul 19, 2020

fejta-bot commented Aug 18, 2020

silenceper commented Sep 3, 2020

pigletfly commented Sep 8, 2020

silenceper commented Sep 15, 2020

soltysh commented Oct 2, 2020

chenkaiyue commented Oct 11, 2020

chenkaiyue commented Oct 15, 2020 •

edited

soltysh left a comment

soltysh Oct 15, 2020

chenkaiyue Oct 15, 2020

chenkaiyue commented Oct 16, 2020

soltysh left a comment

k8s-ci-robot commented Oct 29, 2020

fejta-bot commented Nov 28, 2020

k8s-ci-robot commented Nov 28, 2020

update statefulset pod when it is not running and has ErrImagePullBackOff error #89801

update statefulset pod when it is not running and has ErrImagePullBackOff error #89801

Conversation

chenkaiyue commented Apr 3, 2020 • edited

k8s-ci-robot commented Apr 3, 2020

chenkaiyue commented Apr 3, 2020

ialidzhikov Apr 6, 2020 • edited

Choose a reason for hiding this comment

chenkaiyue Apr 7, 2020

Choose a reason for hiding this comment

chenkaiyue commented Apr 7, 2020

chenkaiyue commented Apr 8, 2020

ialidzhikov commented Apr 20, 2020

fejta-bot commented Jul 19, 2020

fejta-bot commented Aug 18, 2020

silenceper commented Sep 3, 2020

pigletfly commented Sep 8, 2020

silenceper commented Sep 15, 2020

soltysh commented Oct 2, 2020

chenkaiyue commented Oct 11, 2020

chenkaiyue commented Oct 15, 2020 • edited

soltysh left a comment

Choose a reason for hiding this comment

soltysh Oct 15, 2020

Choose a reason for hiding this comment

chenkaiyue Oct 15, 2020

Choose a reason for hiding this comment

chenkaiyue commented Oct 16, 2020

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 29, 2020

fejta-bot commented Nov 28, 2020

k8s-ci-robot commented Nov 28, 2020

chenkaiyue commented Apr 3, 2020 •

edited

ialidzhikov Apr 6, 2020 •

edited

chenkaiyue commented Oct 15, 2020 •

edited