Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubectl] Fail when local source file doesn't exist #90333

Merged
merged 1 commit into from Nov 6, 2020
Merged

[kubectl] Fail when local source file doesn't exist #90333

merged 1 commit into from Nov 6, 2020

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Apr 21, 2020 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

When trying to upload an unexisting file to a pod, kubectl currently doesn't print any error message and terminates with a zero exit code.

This adds a check and fails explicitly in such cases.

Which issue(s) this PR fixes:

Fixes #78879

[kubectl] Fail when local source file doesn't exist

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 21, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @bamarni!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bamarni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 21, 2020
@bamarni
Copy link
Contributor Author

bamarni commented Apr 21, 2020

/assign @deads2k

@bamarni bamarni mentioned this pull request Apr 21, 2020
Closed
@bamarni bamarni force-pushed the kubectl-cp-unexisting-file branch 3 times, most recently from f191d2f to b961c7b Compare April 22, 2020 09:11
@Pingan2017
Copy link
Member

Thanks for you PR !
/ok-to-test
/assign @soltysh

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2020
@bamarni
Copy link
Contributor Author

bamarni commented May 16, 2020

/retest

@bamarni
Copy link
Contributor Author

bamarni commented May 16, 2020

Thanks for checking @Pingan2017, tests failure seemed unrelated so I re-ran them and they passed!

@bamarni
Copy link
Contributor Author

bamarni commented Jun 16, 2020

@soltysh any news on this one?

@dims
Copy link
Member

dims commented Jul 27, 2020

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims July 27, 2020 11:57
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2020
@bamarni
[kubectl] Fail when local source file doesn't exist
3fa5b50 
When trying to upload an unexisting file to a pod,
kubectl currently doesn't print any error message
and terminates with a zero exit code.

This adds a check and fails explicitly in such cases.
@bamarni bamarni force-pushed the kubectl-cp-unexisting-file branch from b961c7b to 3fa5b50 Compare July 27, 2020 14:20
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2020
@bamarni
Copy link
Contributor Author

bamarni commented Jul 27, 2020

/retest

@bamarni
Copy link
Contributor Author

bamarni commented Jul 28, 2020

@Pingan2017 : I've rebased it

@bamarni
Copy link
Contributor Author

bamarni commented Aug 10, 2020

@soltysh : can you take a look?

soltysh
soltysh approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2020
@soltysh
Copy link
Contributor

soltysh commented Nov 6, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bamarni, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1485d46 into kubernetes:master Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 6, 2020
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Open
@ingvagabund ingvagabund mentioned this pull request Nov 30, 2020
Merged
@CaoDonghui123 CaoDonghui123 mentioned this pull request Mar 25, 2021
Closed
@eddiezane eddiezane mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

kubectl cp does not return an error when the source file doesn't exist
6 participants
@bamarni @k8s-ci-robot @Pingan2017 @dims @soltysh @deads2k