Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating Kubelet --enable-server and --provider-id flags to config #90494

Merged
merged 1 commit into from
May 27, 2020
Merged

Migrating Kubelet --enable-server and --provider-id flags to config #90494

merged 1 commit into from
May 27, 2020

Conversation

knabben
Copy link
Member

@knabben knabben commented Apr 25, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup
/area kubelet
/area kubelet-api

What this PR does / why we need it:
Moving Kubelet --enable-server and --provider-id to configuration file.

Which issue(s) this PR fixes:

Refs #86843

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The Kubelet's `--enable-server` and `--provider-id` option is now available via the Kubelet config file field `enableServer` and `providerID` respectively.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @knabben. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2020
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2020
@knabben
Copy link
Member Author

knabben commented Apr 26, 2020

/assign @liggitt

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@knabben knabben mentioned this pull request Apr 26, 2020
Closed
30 tasks
@mtaufen
Copy link
Contributor

mtaufen commented Apr 28, 2020

/ok-to-test
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 28, 2020
@knabben
Copy link
Member Author

knabben commented May 1, 2020

/retest

liggitt
liggitt reviewed May 1, 2020
View reviewed changes
staging/src/k8s.io/kubelet/config/v1beta1/types.go Outdated
@@ -74,6 +74,9 @@ const (
type KubeletConfiguration struct {
metav1.TypeMeta `json:",inline"`

// enableServer enables the Kubelet's server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarify which server this enables (the secured port, I think). might also be worth mentioning that the readonly port is independently controlled.

mtaufen
mtaufen reviewed May 12, 2020
View reviewed changes
staging/src/k8s.io/kubelet/config/v1beta1/types.go Outdated
// providerID, if set, sets the unique id of the instance that an external provider (i.e. cloudprovider)
// can use to identify a specific node.
// Dynamic Kubelet Config (beta): If dynamically updating this field, consider that changing
// the volumePluginDir may disrupt workloads relying on third party volume plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamic config comment needs to be updated to providerID

@knabben knabben force-pushed the kubelet-provider branch 3 times, most recently from e2386fd to 9ae8ccd Compare May 12, 2020 21:02
mtaufen
mtaufen reviewed May 12, 2020
View reviewed changes
pkg/kubelet/apis/config/types.go Outdated
@@ -74,6 +74,9 @@ const (
type KubeletConfiguration struct {
metav1.TypeMeta

// enableServer enables Kubelet's secured server. An insecure port is
// controlled by the readOnlyPort option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this comment to match how we updated the comment on the external type:

	// enableServer enables Kubelet's secured server.
	// Note: Kubelet's insecure port is controlled by the readOnlyPort option.

@knabben
Copy link
Member Author

knabben commented May 13, 2020

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2020
@knabben knabben force-pushed the kubelet-provider branch 2 times, most recently from 99cb59c to 1408f07 Compare May 17, 2020 01:31
@mtaufen
Copy link
Contributor

mtaufen commented May 26, 2020

/lgtm

@liggitt for final review

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020
@liggitt
Copy link
Member

liggitt commented May 26, 2020

/approve

@liggitt liggitt added this to API review completed, 1.19 in API Reviews May 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

@knabben: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind 8459c9b link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knabben
Copy link
Member Author

knabben commented May 27, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 03cd30b into kubernetes:master May 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 27, 2020
@knabben knabben deleted the kubelet-provider branch May 27, 2020 02:26
@github-actions github-actions bot mentioned this pull request Jun 2, 2020
Open
@rfranzke rfranzke mentioned this pull request Aug 17, 2020
Closed
rfranzke added a commit to gardener/gardener-extension-provider-alicloud that referenced this pull request Sep 1, 2020
@rfranzke
Add TODO note for new ways to put provider-id in kubelet config
dc447da 
kubernetes/kubernetes#90494
rfranzke added a commit to gardener/gardener-extension-provider-alicloud that referenced this pull request Sep 3, 2020
@rfranzke
Add TODO note for new ways to put provider-id in kubelet config
08fcf02 
kubernetes/kubernetes#90494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@liggitt liggitt liggitt left review comments

@davidopp davidopp Awaiting requested review from davidopp

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@mtaufen mtaufen

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.19
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@knabben @k8s-ci-robot @fejta-bot @mtaufen @liggitt