Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating Kubelet not used testing flags #90499

Merged
merged 1 commit into from
May 13, 2020
Merged

Deprecating Kubelet not used testing flags #90499

merged 1 commit into from
May 13, 2020

Conversation

knabben
Copy link
Member

@knabben knabben commented Apr 26, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup
/area kubelet
/area kubelet-api

What this PR does / why we need it:

The PR moves testing flags --really-crash-for-testing and --chaos-chance as deprecated.

Which issue(s) this PR fixes:

Ref: #86843

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The Kubelet's `--really-crash-for-testing` and  `--chaos-chance` options are now marked as deprecated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @knabben. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2020
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2020
@knabben knabben mentioned this pull request Apr 26, 2020
Closed
30 tasks
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

mattjmcnaughton
mattjmcnaughton reviewed Apr 26, 2020
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/uncc
/assign @liggitt @yujuhong

I'm afraid I don't have a ton of insights here, so removing myself. Tagging some folks who hopefully have more context :)

mtaufen
mtaufen reviewed Apr 28, 2020
View reviewed changes
cmd/kubelet/app/options/options.go Outdated
@@ -56,11 +56,6 @@ type KubeletFlags struct {
KubeConfig string
BootstrapKubeconfig string

// Insert a probability of random errors during calls to the master.
ChaosChance float64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knabben mentioned this doesn't seem to be used anywhere.
May be better to deprecate and remove after 2 releases.

mtaufen
mtaufen reviewed Apr 28, 2020
View reviewed changes
cmd/kubelet/app/options/options.go Outdated
// Insert a probability of random errors during calls to the master.
ChaosChance float64
// Crash immediately, rather than eating panics.
ReallyCrashForTesting bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt, @BenTheElder do you know if any tests actually set --really-crash-for-testing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cs.k8s.io/?q=really-crash-for-testing&i=nope&files=&repos=

Doesn't look like it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cs.k8s.io/?q=really-crash-for-testing&i=nope&files=&repos=

Doesn't look like it

@mtaufen
Copy link
Contributor

mtaufen commented Apr 28, 2020

/ok-to-test
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2020
@knabben knabben changed the title Migrating Kubelet testing flags to configuration Deprecating Kubelet not used testing flags May 1, 2020
@knabben
Copy link
Member Author

knabben commented May 1, 2020

/test pull-kubernetes-e2e-kind

@knabben
Copy link
Member Author

knabben commented May 1, 2020

/test pull-kubernetes-e2e-kind-ipv6

@knabben
Copy link
Member Author

knabben commented May 3, 2020

@mtaufen @BenTheElder I'm deprecating both flags since they are not being used by sig-testing.

@mtaufen
Copy link
Contributor

mtaufen commented May 12, 2020

/lgtm
/approve

@mtaufen
Copy link
Contributor

mtaufen commented May 12, 2020

/assign @liggitt
for approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@liggitt
Copy link
Member

liggitt commented May 12, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, liggitt, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@knabben
Copy link
Member Author

knabben commented May 13, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2ca3347 into kubernetes:master May 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 13, 2020
@github-actions github-actions bot mentioned this pull request May 27, 2020
Closed
@wangyysde wangyysde mentioned this pull request Apr 13, 2021
Merged
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@mtaufen mtaufen

@liggitt liggitt

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@knabben @k8s-ci-robot @fejta-bot @mtaufen @liggitt @BenTheElder @mattjmcnaughton @yujuhong