Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the server-side dry-run feature as GA #90774

Merged
merged 1 commit into from
May 9, 2020
Merged

Mark the server-side dry-run feature as GA #90774

merged 1 commit into from
May 9, 2020

Conversation

julianvmodesto
Copy link
Contributor

@julianvmodesto julianvmodesto commented May 5, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
APIServer dry-run is GA in 1.18, so we should mark the feature gate accordingly.

We noticed this in #90367 due to a failure by the pull-kubernetes-conformance-kind-ga-only-parallel presubmit that enables GA only features in kind.

Which issue(s) this PR fixes:

#68514

Does this PR introduce a user-facing change?:

NONE

/assign @apelisse
/sig api-machinery
/wg api-expression

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 5, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. wg/api-expression Categorizes an issue or PR as relevant to WG API Expression. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 5, 2020
@julianvmodesto julianvmodesto mentioned this pull request May 5, 2020
Merged
@julianvmodesto
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 5, 2020
@apelisse
Copy link
Member

apelisse commented May 5, 2020

isn't this flag in two places?

@julianvmodesto
Copy link
Contributor Author

Oh yes, found the second location

@apelisse
Copy link
Member

apelisse commented May 5, 2020

One last thing, because we like to make sure we repeat ourselves ;-)

https://github.com/kubernetes/kubernetes/blob/55968f1acb2e0ea95b7bc5d8f2ecd982dea3b425/staging/src/k8s.io/apiserver/pkg/features/kube_features.go#L83-L90

@julianvmodesto
Copy link
Contributor Author

Done

/retest

@apelisse
Copy link
Member

apelisse commented May 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2020
@julianvmodesto
Copy link
Contributor Author

/assign @lavalamp

For feature approval

/retest

@lavalamp
Copy link
Member

lavalamp commented May 7, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, julianvmodesto, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@apelisse
Copy link
Member

apelisse commented May 7, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit dc5b9c1 into kubernetes:master May 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@lavalamp lavalamp

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julianvmodesto @apelisse @lavalamp @k8s-ci-robot @fejta-bot