Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify: Exclude verify-external-dependencies from make verify #91012

Merged
merged 1 commit into from May 18, 2020
Merged

verify: Exclude verify-external-dependencies from make verify #91012

merged 1 commit into from May 18, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

verify: Exclude verify-external-dependencies from make verify

Also:

  • Adds verify-external-dependencies to QUICK_PATTERNS
  • Renames EXCLUDE_GODEP to EXCLUDE_DEPENDENCIES
    (since Godeps has been removed from the repo)

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @cblecker
/hold until after #90963 has merged and has had some soak. Let's say until Monday, 5/18.

Special notes for your reviewer:

(Follow-up from a convo w/ @cblecker yesterday.)

tl;dr -- When we make changes to build/dependencies.yaml, pull-kubernetes-verify appears to not run hack/verify-external-dependencies-version.sh until much later in the job.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 12, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 12, 2020
@justaugustus
Copy link
Member Author

/area dependency
/priority important-soon

Not quite all SIG Release, but needs a SIG, so:
/sig release

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2020
@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-kind

cblecker
cblecker reviewed May 12, 2020
View reviewed changes
hack/make-rules/verify.sh Outdated
# Exclude vendor checks in certain cases, if they're running in a separate job.
if [[ ${EXCLUDE_GODEP:-} =~ ^[yY]$ ]]; then
# Exclude dependency checks in certain cases, if they're running in a separate job.
if [[ ${EXCLUDE_DEPENDENCIES:-} =~ ^[yY]$ ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't change the variable name here, unless we update it throughout test-infra (and we would need to pick it backwards)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cblecker -- reverted that change.

@justaugustus
verify: Exclude verify-external-dependencies from make verify
edb98fb 
Also adds verify-external-dependencies to QUICK_PATTERNS

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/test pull-kubernetes-integration

@justaugustus
Copy link
Member Author

/hold cancel
(since #90963 has merged and it's 5/18 (when we said we'd lift the hold))

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-integration edb98fb link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit ee8731a into kubernetes:master May 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker left review comments

@eparis eparis Awaiting requested review from eparis

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justaugustus @cblecker @k8s-ci-robot