Fix golint error for pkg/kubelet/types #91178

qw1mb0 · 2020-05-17T11:39:04Z

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Fix lint errors for the whole directory pkg/kubelet/types
Remove pkg/kubelet/types from hack/.golint_failures;
Fix some typo from comments.

Which issue(s) this PR fixes: #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2020-05-17T11:39:12Z

Hi @qw1mb0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hwdef · 2020-05-17T15:04:45Z

/ok-to-test
/lgtm for hack

mattjmcnaughton

Two small grammar nits from me, that would be great to clean up while we're working with this code.

Other than that looks good! Feel free to ping me if you make the change and I'll mark as lgtm.

mattjmcnaughton · 2020-05-17T15:59:32Z

pkg/kubelet/types/constants.go

@@ -17,14 +17,17 @@ limitations under the License.
 package types

 const (
-	// system default DNS resolver configuration
+	// ResolvConfDefault define system default DNS resolver configuration


Small nit :) For all of these, I think we want to swap define with defines a.

mattjmcnaughton · 2020-05-17T16:00:02Z

pkg/kubelet/types/labels.go

-	KubernetesPodNameLabel       = "io.kubernetes.pod.name"
-	KubernetesPodNamespaceLabel  = "io.kubernetes.pod.namespace"
-	KubernetesPodUIDLabel        = "io.kubernetes.pod.uid"
+	// KubernetesPodNameLabel specify pod name label


Small nit :) I think we want to swap specify for specifies a.

qw1mb0 · 2020-05-17T16:08:19Z

@mattjmcnaughton I corrected the grammatical errors

mattjmcnaughton

Sorry, one last thought and then looks good to me.

I'll mark lgtm once the final change is made.

mattjmcnaughton · 2020-05-19T02:26:11Z

pkg/kubelet/types/types.go

@@ -61,7 +61,7 @@ func (t *Timestamp) GetString() string {
 	return t.time.Format(time.RFC3339Nano)
 }

-// A type to help sort container statuses based on container names.
+// SortedContainerStatuses a type to help sort container statuses based on container names.


Nit: For this file, I think it could be ConstantName is a...

Nit: For this file, I think it could be ConstantName is a...

fixed

qw1mb0 · 2020-05-26T19:50:17Z

@mattjmcnaughton ping

mattjmcnaughton

Getting close!

Two final thoughts - I clarified one of my earlier comments - I hope it makes sense :) Please lmk if not!

mattjmcnaughton · 2020-05-27T01:50:40Z

pkg/kubelet/types/types.go

@@ -95,8 +95,8 @@ type Reservation struct {
 	Kubernetes v1.ResourceList
 }

-// A pod UID which has been translated/resolved to the representation known to kubelets.
+// ResolvedPodUID a pod UID which has been translated/resolved to the representation known to kubelets.


Sorry, I wasn't clear in my original comment - we should also add the is a change for ResolvedPodUID and MirrorPodUID similar to SortedContainerStatuses.

mattjmcnaughton · 2020-05-27T01:51:43Z

pkg/kubelet/types/labels.go

 	KubernetesContainerNameLabel = "io.kubernetes.container.name"
 )

+// GetContainerName return container name from labels


Nit: For all the functions in this file, I think we want FuncName returns ....

qw1mb0 · 2020-05-29T21:08:07Z

/retest

mattjmcnaughton

/lgtm

Thank you for these fixes!

sijocherian · 2020-06-11T22:15:47Z

/retest

SergeyKanzhelev · 2020-06-19T21:04:09Z

/assign @dashpole

dashpole · 2020-06-19T21:53:37Z

/lgtm
/approve

k8s-ci-robot · 2020-06-19T21:53:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole, qw1mb0
To complete the pull request process, please assign vishh
You can assign the PR to them by writing /assign @vishh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

hack/OWNERS
~~pkg/kubelet/OWNERS~~ [dashpole]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SergeyKanzhelev · 2020-06-19T23:46:43Z

/assign @dims

SergeyKanzhelev · 2020-06-24T04:14:44Z

pkg/kubelet/types/pod_update.go

@@ -25,42 +25,47 @@ import (
 )

 const (
-	ConfigSourceAnnotationKey    = "kubernetes.io/config.source"
-	ConfigMirrorAnnotationKey    = v1.MirrorPodAnnotationKey
+	// ConfigSourceAnnotationKey specifies a annotation key for config source


nit

Suggested change

// ConfigSourceAnnotationKey specifies a annotation key for config source

// ConfigSourceAnnotationKey specifies an annotation key for config source

SergeyKanzhelev · 2020-06-24T04:14:55Z

pkg/kubelet/types/pod_update.go

-	ConfigMirrorAnnotationKey    = v1.MirrorPodAnnotationKey
+	// ConfigSourceAnnotationKey specifies a annotation key for config source
+	ConfigSourceAnnotationKey = "kubernetes.io/config.source"
+	// ConfigMirrorAnnotationKey specifies a annotation key for config mirror


Suggested change

// ConfigMirrorAnnotationKey specifies a annotation key for config mirror

// ConfigMirrorAnnotationKey specifies an annotation key for config mirror

SergeyKanzhelev · 2020-06-24T04:16:30Z

pkg/kubelet/types/constants.go


-	// User visible keys for managing node allocatable enforcement on the node.
+// User visible keys for managing node allocatable enforcement on the node.
+const (
 	NodeAllocatableEnforcementKey = "pods"


curious why these const do not require a comment

SergeyKanzhelev · 2020-06-25T19:59:39Z

/priority backlog

SergeyKanzhelev · 2020-09-14T20:35:32Z

@qw1mb0 would you please rebase this PR?

k8s-ci-robot · 2020-09-14T20:35:40Z

@qw1mb0: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2020-12-13T20:58:49Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

SergeyKanzhelev · 2020-12-23T22:59:50Z

new attempt is here: #97374

/close

k8s-ci-robot · 2020-12-23T23:00:02Z

@SergeyKanzhelev: Closed this PR.

In response to this:

new attempt is here: #97374

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2020

k8s-ci-robot requested review from hwdef and Random-Liu May 17, 2020 11:40

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 17, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2020

mattjmcnaughton suggested changes May 17, 2020

View reviewed changes

qw1mb0 force-pushed the fix-golint-kubelet-types branch from 9d7b0a6 to 7d0b0ab Compare May 17, 2020 16:06

mattjmcnaughton suggested changes May 19, 2020

View reviewed changes

qw1mb0 force-pushed the fix-golint-kubelet-types branch from 7d0b0ab to 8c524e5 Compare May 21, 2020 19:41

mattjmcnaughton suggested changes May 27, 2020

View reviewed changes

fix golint error for pkg/kubelet/types

16e3467

qw1mb0 force-pushed the fix-golint-kubelet-types branch from 8c524e5 to 16e3467 Compare May 29, 2020 20:09

mattjmcnaughton approved these changes Jun 1, 2020

View reviewed changes

k8s-ci-robot assigned mattjmcnaughton Jun 1, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020

SergeyKanzhelev approved these changes Jun 19, 2020

View reviewed changes

k8s-ci-robot assigned dashpole Jun 19, 2020

k8s-ci-robot assigned dims Jun 19, 2020

SergeyKanzhelev reviewed Jun 24, 2020

View reviewed changes

k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2020

dims removed their assignment Jul 26, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2020

k8s-ci-robot closed this Dec 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix golint error for pkg/kubelet/types #91178

Fix golint error for pkg/kubelet/types #91178

qw1mb0 commented May 17, 2020 •

edited

k8s-ci-robot commented May 17, 2020

hwdef commented May 17, 2020

mattjmcnaughton left a comment

mattjmcnaughton May 17, 2020

qw1mb0 May 17, 2020

mattjmcnaughton May 17, 2020

qw1mb0 May 17, 2020

qw1mb0 commented May 17, 2020

mattjmcnaughton left a comment

mattjmcnaughton May 19, 2020

qw1mb0 May 21, 2020

qw1mb0 commented May 26, 2020

mattjmcnaughton left a comment

mattjmcnaughton May 27, 2020

qw1mb0 May 29, 2020

mattjmcnaughton May 27, 2020

qw1mb0 May 29, 2020

qw1mb0 commented May 29, 2020

mattjmcnaughton left a comment

sijocherian commented Jun 11, 2020

SergeyKanzhelev commented Jun 19, 2020

dashpole commented Jun 19, 2020

k8s-ci-robot commented Jun 19, 2020

SergeyKanzhelev commented Jun 19, 2020

SergeyKanzhelev Jun 24, 2020

SergeyKanzhelev Jun 24, 2020

SergeyKanzhelev Jun 24, 2020

SergeyKanzhelev commented Jun 25, 2020

SergeyKanzhelev commented Sep 14, 2020

k8s-ci-robot commented Sep 14, 2020

fejta-bot commented Dec 13, 2020

SergeyKanzhelev commented Dec 23, 2020

k8s-ci-robot commented Dec 23, 2020

	// ConfigSourceAnnotationKey specifies a annotation key for config source
	// ConfigSourceAnnotationKey specifies an annotation key for config source

	// ConfigMirrorAnnotationKey specifies a annotation key for config mirror
	// ConfigMirrorAnnotationKey specifies an annotation key for config mirror

Fix golint error for pkg/kubelet/types #91178

Fix golint error for pkg/kubelet/types #91178

Conversation

qw1mb0 commented May 17, 2020 • edited

k8s-ci-robot commented May 17, 2020

hwdef commented May 17, 2020

mattjmcnaughton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qw1mb0 commented May 17, 2020

mattjmcnaughton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qw1mb0 commented May 26, 2020

mattjmcnaughton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qw1mb0 commented May 29, 2020

mattjmcnaughton left a comment

Choose a reason for hiding this comment

sijocherian commented Jun 11, 2020

SergeyKanzhelev commented Jun 19, 2020

dashpole commented Jun 19, 2020

k8s-ci-robot commented Jun 19, 2020

SergeyKanzhelev commented Jun 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeyKanzhelev commented Jun 25, 2020

SergeyKanzhelev commented Sep 14, 2020

k8s-ci-robot commented Sep 14, 2020

fejta-bot commented Dec 13, 2020

SergeyKanzhelev commented Dec 23, 2020

k8s-ci-robot commented Dec 23, 2020

qw1mb0 commented May 17, 2020 •

edited