Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update metrics to conform promlint #91448

Merged
merged 1 commit into from May 28, 2020
Merged

update metrics to conform promlint #91448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/scheduler/metrics/metrics.go
View file
Open in desktop
Expand Up @@ -145,7 +145,7 @@ var (
PreemptionAttempts = metrics.NewCounter(
&metrics.CounterOpts{
Subsystem: SchedulerSubsystem,
Name: "total_preemption_attempts",
Name: "preemption_attempts_total",
Help: "Total preemption attempts in the cluster till now",
StabilityLevel: metrics.ALPHA,
})
Expand Down
3 changes: 0 additions & 3 deletions staging/src/k8s.io/component-base/metrics/testutil/promlint.go
View file
Open in desktop
Expand Up @@ -53,9 +53,6 @@ var exceptionMetrics = []string{
// kube-proxy
"kubernetes_build_info",

// kube-scheduler
"scheduler_total_preemption_attempts",

// kubelet-resource-v1alpha1
"container_cpu_usage_seconds_total",
"node_cpu_usage_seconds_total",
Expand Down