Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure strict encoding for RequestedToCapacityRatioArgs #91603

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Configure strict encoding for RequestedToCapacityRatioArgs #91603

merged 1 commit into from
Jun 23, 2020

Conversation

pancernik
Copy link
Contributor

What type of PR is this?
/kind api-change

What this PR does / why we need it:
1.18 shipped v1alpha2 Kube Scheduler Plugin Args. RequestedToCapacityRatioArgs allowed case-insenstive encoding of Shape and Resources fields. v1beta1 disallows this enabling strict encoding for these plugin args.

Which issue(s) this PR fixes:

Part of #89701

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`RequestedToCapacityRatioArgs` encoding is now strict

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/30bc12a2e26a06a1995c379df125fc6f6ae58e77/keps/sig-scheduling/785-scheduler-component-config-api

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pancernik. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2020
@pancernik
Copy link
Contributor Author

/cc @alculquicondor

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 30, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@pancernik
Copy link
Contributor Author

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label May 30, 2020
alculquicondor
alculquicondor reviewed Jun 2, 2020
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
from scheduler
/assign @liggitt

pkg/scheduler/apis/config/scheme/scheme_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@alculquicondor
Copy link
Member

/hold
can you just fix the v1beta1 types instead of using the v1 ones? We can de-duplicate once we graduate the API to GA. But this keeps the possibility open for the types to evolve differently in v1beta1.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2020
@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2020
@alculquicondor
Copy link
Member

Please follow suggestion here #91580 (comment) regarding release notes.

@pancernik pancernik force-pushed the v1beta1-requested-to-cap-ratio-encoding branch from 7a29772 to 6106440 Compare June 6, 2020 17:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2020
@pancernik pancernik force-pushed the v1beta1-requested-to-cap-ratio-encoding branch from da78e4a to ead958a Compare June 6, 2020 17:28
@pancernik
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

alculquicondor
alculquicondor reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2020
@pancernik pancernik force-pushed the v1beta1-requested-to-cap-ratio-encoding branch from ead958a to 4b55480 Compare June 12, 2020 12:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2020
@pancernik pancernik force-pushed the v1beta1-requested-to-cap-ratio-encoding branch from 4b55480 to 707e1eb Compare June 12, 2020 13:55
@alculquicondor
Copy link
Member

/unassign @liggitt

/assign @lavalamp

@k8s-ci-robot k8s-ci-robot assigned lavalamp and unassigned liggitt Jun 12, 2020
@pancernik
Copy link
Contributor Author

/retest

@pancernik
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@liggitt
Copy link
Member

liggitt commented Jun 22, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, pancernik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@alculquicondor
Copy link
Member

/hold cancel

Thanks @pancernik!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@alculquicondor
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@pancernik: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 707e1eb link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 819ad44 into kubernetes:master Jun 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 23, 2020
@github-actions github-actions bot mentioned this pull request Jun 30, 2020
Open
@pancernik pancernik mentioned this pull request Jul 3, 2020
Closed
6 tasks
@alculquicondor alculquicondor mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ahg-g ahg-g ahg-g left review comments

@eparis eparis Awaiting requested review from eparis

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@lavalamp lavalamp

@liggitt liggitt

@alculquicondor alculquicondor

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pancernik @k8s-ci-robot @fejta-bot @alculquicondor @liggitt @ahg-g @lavalamp