New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start to kill the word "minion" #9176
Conversation
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
Awesome! |
Ref #1111 |
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
Looks pretty reasonable to me. Did you run e2e? |
Did not run e2e yet, no time today. On Wed, Jun 3, 2015 at 10:30 PM, Brian Grant notifications@github.com
|
So to confirm: the new names are masters & nodes? And a master is not a node? (I have a PR coming for configuring security groups for AWS, and was going to give the masters & TNFKAM* different security groups; I might as well give them the right names if I can) (* the nodes formerly known as minions) |
The current name is node. The "master" is currently not a full schedulable node running kubelet, kube-proxy, etc., but that's the future -- self-hosting of the control plane (see #246 for some old discussion). |
To surface a side discussion from a meeting - maybe we're over the hump of On Thu, Jun 4, 2015 at 3:04 PM, Brian Grant notifications@github.com
|
|
@thockin - what is the plan for this PR? Are we going to proceed with it or should we close it? |
GCE e2e build/test failed for commit cefdc5d. |
Labelling this PR as size/XL |
@thockin - what is the plan for this PR? Are we going to proceed with it or should we close it? |
We should still do it, but this PR is pretty obsolete. On Tue, Sep 8, 2015 at 5:08 AM, Wojciech Tyczynski <notifications@github.com
|
@thockin can we close this one? It might be easier to start it from scratch than to rebase this one :) |
@thockin - thanks. I can try to redo some if it in my free cycles. |
I still think we should use "minion" in cases where we are referring to something that can only be a worker node. Even once we have self-hosting I think it will be a useful distinction as some people won't want to share their master nodes with user containers for security and performance isolation reasons. |
@davidopp can you please give an example of where you think we should leave minion? From what you wrote it seems to me that you're referring to places that are exposed to user (e.g. kube-up script?). |
Mostly mechanican changes that were pretty obvious.
This series is sort of risky. I think we only want the first commit here and the rest later? Need to do docs, too, and that is pretty manual.
I don't think I changed any "minion" string where the context was salt (for which "minion" is correct")