Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate ServiceAccountIssuerDiscovery to beta #91921

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Graduate ServiceAccountIssuerDiscovery to beta #91921

merged 1 commit into from
Sep 12, 2020

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Jun 8, 2020 •
edited
Loading

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Graduates the ServiceAccountIssuerDiscovery feature to beta.

Which issue(s) this PR fixes:
Enhancement: kubernetes/enhancements#1393

Special notes for your reviewer:
ServiceAccountIssuerDiscovery satisfies the graduation criteria in the KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/20190730-oidc-discovery.md

Does this PR introduce a user-facing change?:

The ServiceAccountIssuerDiscovery feature gate is now Beta and enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2020
@mtaufen mtaufen added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jun 8, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 8, 2020
@mtaufen mtaufen added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 8, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 8, 2020
@mtaufen mtaufen mentioned this pull request Jun 8, 2020
Closed
12 tasks
@mtaufen
Copy link
Contributor Author

mtaufen commented Jun 8, 2020

/assign @mikedanese

@mikedanese
Copy link
Member

Why is this WIP?

@mtaufen mtaufen changed the title [WIP] Graduate ServiceAccountIssuerDiscovery to beta Graduate ServiceAccountIssuerDiscovery to beta Sep 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 10, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member

liggitt commented Sep 11, 2020

enabling this modifies the default RBAC policies, see the unit test failure. regenerate and commit the changed bootstrap policy

@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2020
@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 11, 2020

Done

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2020
@mikedanese
Copy link
Member

🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@liggitt liggitt added this to the v1.20 milestone Sep 11, 2020
@liggitt
Copy link
Member

liggitt commented Sep 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2cb951d into kubernetes:master Sep 12, 2020
@github-actions github-actions bot mentioned this pull request Sep 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mtaufen @mikedanese @fejta-bot @liggitt @k8s-ci-robot