WIP: Fail pod creation if resolv.conf too long #9230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surfaces to user the misconfiguration issue described in #9079 |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
cc @thockin |
|
Idea LGTM |
| // Also, this might be different with ipv6? | ||
| // TODO(erictune): get docker and rkt to warn about exceeding this limit? | ||
| if len(opts.DNSSearch) > glibcMaxResolvConfSearchEntries { | ||
| return nil, fmt.Errorf("Cluster DNS configuration error: more than %d search entries required", glibcMaxResolvConfSearchEntries) |
There was a problem hiding this comment.
should the text use "specified" instead of "required"
|
helps with #8512 |
|
Fixed comments. |
|
Not sure when I'll get back to writing a test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs e2e testing.