Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance agnhost netexec for SSRF E2Es #92850

Merged
merged 5 commits into from Nov 3, 2020
Merged

Enhance agnhost netexec for SSRF E2Es #92850

merged 5 commits into from Nov 3, 2020

Conversation

tallclair
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

This adds 3 pieces of functionality that will be used in an upcoming PR to add regression tests for some recent fixes for SSRF vulnerabilities:

  1. Allow setting a custom response status code with the echo endpoint
  2. Add a new redirect endpoint that responds with a redirect to the desired location
  3. Add an option to override the URL and always use the specified handler
NONE

/area test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 7, 2020
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 7, 2020
@tallclair
Copy link
Member Author

/assign @claudiubelu

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020
@tallclair
Copy link
Member Author

/retest

@claudiubelu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2020
@claudiubelu
Copy link
Contributor

/test pull-kubernetes-e2e-kind

@claudiubelu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@tallclair tallclair mentioned this pull request Jul 23, 2020
Closed
@claudiubelu
Copy link
Contributor

The milestone should probably be updated for this to merge.

@tallclair tallclair added this to the v1.20 milestone Sep 22, 2020
@tabbysable tabbysable mentioned this pull request Sep 26, 2020
Open
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2020
@sayanchowdhury
Copy link
Member

👋🏽 Hi @tallclair ! I'm from the Bug Triage Team! I see that the PR was approved earlier. The code freeze for 1.20 release is starting November 12th which is about 3 weeks from now.

As the PR is tagged for 1.20, is it still planned for this release?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2020
@tallclair
Copy link
Member Author

trivial rebase, retagging.

@tallclair tallclair added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 17376e6 into kubernetes:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiubelu claudiubelu claudiubelu left review comments

@listx listx Awaiting requested review from listx

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tallclair @claudiubelu @k8s-ci-robot @fejta-bot @sayanchowdhury