Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: deprecate azure blob disk feature #92905

Merged
merged 1 commit into from Jul 12, 2020
Merged

doc: deprecate azure blob disk feature #92905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/volume/azure_dd/azure_common.go
View file
Open in desktop
Expand Up @@ -59,8 +59,8 @@ var (
string(api.AzureDataDiskCachingReadWrite))

supportedDiskKinds = sets.NewString(
string(api.AzureSharedBlobDisk),
string(api.AzureDedicatedBlobDisk),
string(api.AzureSharedBlobDisk), // deprecated
string(api.AzureDedicatedBlobDisk), // deprecated
string(api.AzureManagedDisk))

// only for Windows node
Expand Down
2 changes: 1 addition & 1 deletion pkg/volume/azure_dd/azure_provision.go
View file
Open in desktop
Expand Up @@ -303,7 +303,7 @@ func (p *azureDiskProvisioner) Provision(selectedNode *v1.Node, allowedTopologie
if err != nil {
return nil, err
}
} else {
} else { // Attention: blob disk feature is deprecated
if kind == v1.AzureDedicatedBlobDisk {
_, diskURI, _, err = diskController.CreateVolume(name, account, storageAccountType, location, requestGiB)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController.go
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ import (
"k8s.io/klog/v2"
)

// Attention: blob disk feature is deprecated
const (
vhdContainerName = "vhds"
useHTTPSForBlobBasedDisk = true
Expand Down