Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes 92907 improves test error output #92908

Merged
merged 2 commits into from Jul 12, 2020
Merged

fixes 92907 improves test error output #92908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10bdcb8
fixes 92907 improves test error output
RobertKielty Jul 8, 2020
8e1548f
lowercases start of the fmt.Errorf msg as per convention, fixes spell…
RobertKielty Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e_node/node_problem_detector_linux.go
View file
Open in desktop
Expand Up @@ -419,7 +419,7 @@ func verifyEvents(e coreclientset.EventInterface, options metav1.ListOptions, nu
count += int(event.Count)
}
if count != num {
return fmt.Errorf("expect event number %d, got %d: %v", num, count, events.Items)
return fmt.Errorf("expected %d events with reason set to %s and message set to %s\nbut %d actual events occurred. Events : %v", num, reason, message, count, events.Items)
}
return nil
}
Expand All @@ -435,7 +435,7 @@ func verifyTotalEvents(e coreclientset.EventInterface, options metav1.ListOption
count += int(event.Count)
}
if count != num {
return fmt.Errorf("expect event number %d, got %d: %v", num, count, events.Items)
return fmt.Errorf("expected total number of events was %d, actual events counted was %d\nEvents : %v", num, count, events.Items)
}
return nil
}
Expand Down